Bug 1349270

Summary:	ganesha.enable remains on in volume info file even after we disable nfs-ganesha on the cluster.
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	ganesha-nfs	Assignee:	Jiffin <jthottan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs, jthottan, kkeithle, mzywusko, ndevos, rhs-bugs, skoduri, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1347923
Clones:	1351151 (view as bug list)		Environment:
Last Closed:	2017-03-27 18:26:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1347923
Bug Blocks:	1351151

Comment 1 Vijay Bellur 2016-06-23 06:42:11 UTC

REVIEW: http://review.gluster.org/14778 (glusterd/ganesha : persist value set by teardown in info file) posted (#1) for review on master by jiffin tony Thottan (jthottan)

Comment 2 Vijay Bellur 2016-06-23 13:39:29 UTC

COMMIT: http://review.gluster.org/14778 committed in master by Atin Mukherjee (amukherj) 
------
commit 16c34b101f604a09a5c735fb39815c59ee4ecbdb
Author: Jiffin Tony Thottan <jthottan>
Date:   Thu Jun 23 11:56:10 2016 +0530

    glusterd/ganesha : persist value set by teardown in info file
    
    During teardown, all the volumes exported via NFS-Ganesha will be
    unexported. So all related volume options need to reset. Currently
    this change made using dict_set on volopt dictionary, i.e change
    is only reflected in memory not persisted in the volume info file
    Therefore incase of glusterd restart this data can be lost.
    
    Also this patch fix similar issue in ganesha_manage_export().
    
    Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
    BUG: 1349270
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/14778
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Vijay Bellur 2016-07-07 12:55:34 UTC

REVIEW: http://review.gluster.org/14871 (features/ganesha : remove ganesha xlator from client graph) posted (#1) for review on master by jiffin tony Thottan (jthottan)

Comment 4 Vijay Bellur 2016-08-01 04:10:26 UTC

COMMIT: http://review.gluster.org/14871 committed in master by Atin Mukherjee (amukherj) 
------
commit 6a29c76ae629d17d276c96b2e50f0b43e5fdf309
Author: Jiffin Tony Thottan <jthottan>
Date:   Thu Jul 7 15:55:07 2016 +0530

    features/ganesha : remove ganesha xlator from client graph
    
    The ganesha introduced in dummy xlator in the client graph, which is used
    for introducing the cli options. When the volume set command "ganesha.enable"
    ran, this xlator will add into client graph but never removed from it. In my
    opinion there is no point in adding the ganesha xlator in the client graph
    
    Change-Id: I926c4b4adf991361aa459679e275cb58246c5294
    BUG: 1349270
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/14871
    CentOS-regression: Gluster Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 5 Shyamsundar 2017-03-27 18:26:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/