Bug 1349499

Summary: Saving filter errs Search Name is required even when value is filled in
Product: Red Hat CloudForms Management Engine Reporter: Matouš Mojžíš <mmojzis>
Component: UI - OPSAssignee: Jozef Zigmund <jzigmund>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: abellott, dajohnso, hkataria, jhardy, jzigmund, mmojzis, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: filter
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1412316 (view as bug list) Environment:
Last Closed: 2017-06-12 16:30:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1412316    

Description Matouš Mojžíš 2016-06-23 14:40:08 UTC
Description of problem:
Sometimes when I try to save filter I get error "Search Name is required".

Version-Release number of selected component (if applicable):
5.6.0.12

How reproducible:
50%

Steps to Reproduce:
1. Add advanced search filter
2. Save it
3.

Actual results:
Search Name is required and values are reseted

Expected results:


Additional info:

Comment 2 Matouš Mojžíš 2016-06-23 15:20:35 UTC
It looks like this is happening only to fresh appliances with no filters in its category and only sometimes.

Comment 3 Harpreet Kataria 2016-10-17 21:20:04 UTC
Jozef,

Can you look into this issue, from description looks like maybe form data is not being sent upto server, let me know if you need help looking into this one. Not sure if other 2 BZs in this area are also related, i will send those your way too
https://bugzilla.redhat.com/show_bug.cgi?id=1349511
https://bugzilla.redhat.com/show_bug.cgi?id=1349519

Thanks,
~Harpreet

Comment 4 Jozef Zigmund 2016-11-21 17:35:30 UTC
I was not able to reproduce that on current master branch (also tried to reproduce with clean DB). Could you please verify it?

Comment 5 CFME Bot 2016-11-25 21:01:10 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b733f1f63d31c8e36733d717709d5af19347eedf

commit b733f1f63d31c8e36733d717709d5af19347eedf
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Wed Nov 23 17:27:04 2016 +0100
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Wed Nov 23 17:27:04 2016 +0100

    Fix the form field 'Save search as' of an Advanced Search when saving the search with empty name
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1349519
    https://bugzilla.redhat.com/show_bug.cgi?id=1349511
    https://bugzilla.redhat.com/show_bug.cgi?id=1349499

 app/views/layouts/_adv_search_body.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 Matouš Mojžíš 2016-11-30 11:03:09 UTC
It works on upstream, but on 5.7.0.12 I can still see this error.

Comment 7 Matouš Mojžíš 2016-12-07 12:33:38 UTC
Still not working in 5.7.0.14.

Comment 9 Jozef Zigmund 2017-01-11 17:52:27 UTC
Could you please verify if you can still see the error on 5.7 build ?

Comment 11 Matouš Mojžíš 2017-01-20 11:22:26 UTC
Still not working on 5.7.0.17.

Comment 12 Matouš Mojžíš 2017-04-25 10:36:11 UTC
Verified in 5.8.0.11. This error no longer exists when value is filled in.