Bug 1349511

Summary:	When saving filter sometimes errs Name has been taken even when there was no filter with same name
Product:	Red Hat CloudForms Management Engine	Reporter:	Matouš Mojžíš <mmojzis>
Component:	UI - OPS	Assignee:	Jozef Zigmund <jzigmund>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Matouš Mojžíš <mmojzis>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.6.0	CC:	abellott, dajohnso, hkataria, jhardy, jzigmund, mmojzis, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	filter
Fixed In Version:	5.8.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1412315 (view as bug list)		Environment:
Last Closed:	2017-06-12 17:06:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1412315

Description Matouš Mojžíš 2016-06-23 14:59:06 UTC

Description of problem:
Sometimes when I try to save filter Name has been taken error appears and save filter as value is filled by name of filter I saved before. Then when I click on save it tells me, that all is okay and saves it with value I insterted when that error appears even though this time it was filled by name of previous filter. Then flash message tells me it wasn't saved with value of previous filter, but with value, which made that error. It acts really weird. It doesn't happen often.

Version-Release number of selected component (if applicable):
5.6.0.12

How reproducible:
10%

Steps to Reproduce:
1. Add a filter in advanced search
2. Save it
3.

Actual results:
Name has been taken error

Expected results:
No errors

Additional info:

Comment 2 Harpreet Kataria 2016-10-17 21:20:34 UTC

Jozef,

Can you look into this issue, from description looks like maybe form data is not being sent upto server, let me know if you need help looking into this one. Not sure if other 2 BZs in this area are also related, i will send those your way too
https://bugzilla.redhat.com/show_bug.cgi?id=1349499
https://bugzilla.redhat.com/show_bug.cgi?id=1349519

Thanks,
~Harpreet

Comment 3 Jozef Zigmund 2016-11-22 16:54:38 UTC

I was not able to reproduce the bug on current master branch. Could you please verify it?

Comment 4 CFME Bot 2016-11-25 21:01:05 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/b733f1f63d31c8e36733d717709d5af19347eedf

commit b733f1f63d31c8e36733d717709d5af19347eedf
Author:     Jozef Zigmund <jzigmund>
AuthorDate: Wed Nov 23 17:27:04 2016 +0100
Commit:     Jozef Zigmund <jzigmund>
CommitDate: Wed Nov 23 17:27:04 2016 +0100

    Fix the form field 'Save search as' of an Advanced Search when saving the search with empty name
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1349519
    https://bugzilla.redhat.com/show_bug.cgi?id=1349511
    https://bugzilla.redhat.com/show_bug.cgi?id=1349499

 app/views/layouts/_adv_search_body.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 5 Matouš Mojžíš 2016-11-30 11:03:04 UTC

It works on upstream, but on 5.7.0.12 I can still see this error.

Comment 6 Matouš Mojžíš 2016-12-07 12:34:11 UTC

Still not working on 5.7.0.14.

Comment 8 Jozef Zigmund 2017-01-11 17:54:37 UTC

Could you please verify if you can still see the error on 5.7 build ?

Comment 10 Matouš Mojžíš 2017-01-20 11:22:39 UTC

Still not working on 5.7.0.17.

Comment 11 Matouš Mojžíš 2017-04-25 10:37:35 UTC

Verified in 5.8.0.11. This longer no longer exists where there is no filter with same name.