Bug 1349904

Summary:	Review Request: perl-Module-Install-Contributors - Add an x_contributors section to your META.yml
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Module-Install-Contributors-0.001-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-27 14:32:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1349910

Description Petr Pisar 2016-06-24 13:31:33 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Module-Install-Contributors/perl-Module-Install-Contributors.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Install-Contributors/perl-Module-Install-Contributors-0.001-1.fc25.src.rpm
Description:
This is a plugin for Module::Install. It adds an x_contributors section to
your META.yml file. This is an array of strings, which should normally be in
"Name <email>" format, that is passed to contributors() function in
a Makefile.PL.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-27 09:09:58 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Module-Install-Contributors-0.001-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Module::Install::Base)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Module-Install-Contributors-0.001-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Module::Install::Contributors) = 0.001
      1 perl-Module-Install-Contributors = 0.001-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Module-Install-Contributors*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-06-27 13:57:17 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Module-Install-Contributors

Comment 3 Petr Pisar 2016-06-27 14:32:16 UTC

Thank you for the review and the repository.