Bug 1349967

Summary: Fix warning: "IN_MODULE" redefined [enabled by default]
Product: Red Hat Enterprise Linux 7 Reporter: Carlos O'Donell <codonell>
Component: glibcAssignee: Florian Weimer <fweimer>
Status: CLOSED ERRATA QA Contact: Alexandra Petlanová Hájková <ahajkova>
Severity: low Docs Contact: Vladimír Slávik <vslavik>
Priority: unspecified    
Version: 7.3CC: ahajkova, ashankar, fweimer, hannsj_uhl, mcermak, mnewsome, pfrankli, skolosov, vslavik
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glibc-2.17-226.el7 Doc Type: No Doc Update
Doc Text:
undefined
 Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 09:36:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1505492, 1505884    

Description Carlos O'Donell 2016-06-24 16:30:40 UTC 
The rtkaio build should no longer define IN_MODULE, this was a workaround at one point to include itself in the librt symbol set, but all we need is MODULE_NAME for the final set of patches. Therefore removing `-UIN_MODULE -DIN_MODULE=MODULE_librt` and verifying that the ABI does not change (use libabigail) then it should be fine.

e.g.

In file included from <command-line>:0:0:
./../include/libc-symbols.h:23:0: warning: "IN_MODULE" redefined [enabled by default]
 #define IN_MODULE PASTE_NAME (MODULE_, MODULE_NAME)
 ^

rtkaio/Makefile:

 72 CPPFLAGS-librtkaio += -UIN_MODULE -DIN_MODULE=MODULE_librt \
 73                       -UMODULE_NAME -DMODULE_NAME=librt \
 74                       -UIS_IN_librt -DIS_IN_librt=1 \
 75                       -I$(..)rt
Comment 7 errata-xmlrpc 2018-10-30 09:36:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3092