Bug 1350104

Summary:	the run-tests-in-vagrant.sh script should exit with an error if tests failed
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	tests	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	mainline	CC:	atumball, bugs, rtalur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-02 04:09:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2016-06-25 15:32:26 UTC

Description of problem:
When ./run-tests-in-vagrant.sh runs the regression tests, and tests fail, the script does not exit with an error. This makes it impossible for a CI to report the correct result.

Version-Release number of selected component (if applicable):
3.8 and mainline

How reproducible:
100%

Steps to Reproduce:
1. run ./run-tests-in-vagrant.sh --os=centos6
2. see it fail
3. check the return status with: echo $?

Actual results:
Jenkins notes a return value of 0 as SUCCESS

Expected results:
the script should exit with a non-zero value

Additional info:
See the output of this job in the CentOS CI:
  https://ci.centos.org/view/Gluster/job/gluster_run-tests-in-vagrant/10/console

Comment 1 Amar Tumballi 2019-07-02 04:09:04 UTC

We have a good set of regression right now, and in last year or so, never had any one using run-tests-with-vagrant.sh. Inclined towards not working on this.