Bug 1350758
| Summary: | Too many spamming emails being sent from hipervisors in case of an error. | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Nikolai Sednev <nsednev> |
| Component: | Bindings-API | Assignee: | Piotr Kliczewski <pkliczew> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Lukas Svaty <lsvaty> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.18.4 | CC: | bugs, mperina, msivak, oourfali, sbonazzo, sites-redhat |
| Target Milestone: | --- | Flags: | rule-engine:
planning_ack?
rule-engine: devel_ack? rule-engine: testing_ack? |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-29 12:13:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1343005 | ||
| Bug Blocks: | |||
|
Description
Nikolai Sednev
2016-06-28 10:08:11 UTC
As mentioned in BZ1343005, we needed to revert the fix for BZ1343005 in vdsm-4.18.4.1 because it caused BZ1349461, hopefully both fixes will be part of next VDSM release (In reply to Martin Perina from comment #1) > As mentioned in BZ1343005, we needed to revert the fix for BZ1343005 in > vdsm-4.18.4.1 because it caused BZ1349461, hopefully both fixes will be part > of next VDSM release Sure, but I mean that email notifications should be minimized and we have to prevent spamming our customers with the same errors. Once the original issue is fixed there will be no spam. Closing this one as NOTABUG. (In reply to Oved Ourfali from comment #3) > Once the original issue is fixed there will be no spam. > Closing this one as NOTABUG. Strongly disagree, in case of the same issue being triggered, then the same email message being sent over and over again, please consider redesigning the notifier and reopening this bug. There are mechanisms to prevent event flood. This is a per-vertical decision with regards to their events. Nothing to fix here in general. (In reply to Oved Ourfali from comment #5) > There are mechanisms to prevent event flood. > This is a per-vertical decision with regards to their events. > Nothing to fix here in general. Sure, if there are mechanisms to prevent this from happening from the https://bugzilla.redhat.com/show_bug.cgi?id=1317468, then I'm OK with it. I'd be rather changing to won't fix, as this issue was already fixed in https://bugzilla.redhat.com/show_bug.cgi?id=1317468, but customer's report about email spam was before that fix. I'm the reporter of this bug. It was reported _after_ bug 1317468 and as far as I can tell has nothing to do with bug 1317468. If there's a way currently to rate limit HE notifications can you please tell me where it is? I agree that bug 1343005 is the direct cause of my issue and if that bug is ever resolved it will be mitigated substantially. But there may be other reasons why an HA agent may be shut down / fail and I believe oVirt could do a smarter job managing the resulting onslaught of alerts. Redirecting the needinfo to Martin who owns the notification code within HA daemons. The agent won't send anything when it shuts down or dies. Rate limiting is not supported, but you can limit according to the state transition description. Check the /etc/ovirt-hosted-engine-ha/broker.conf and specifically the [notify] section in that file. The state_transition key contains a regular expression that is used as a trigger for sending an email (case insensitive). |