Bug 1351138 (python-github3py)
| Summary: | Review Request: python-github3py - Python wrapper for the GitHub API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | William Moreno <williamjmorenor> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, williamjmorenor |
| Target Milestone: | --- | Flags: | williamjmorenor:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-18 18:28:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1351097 | ||
| Bug Blocks: | 1351161 | ||
|
Description
Igor Gnatenko
2016-06-29 10:42:10 UTC
Not marking as dependent on python-betamax-matches as it's needed only for tests which require network (so those are not used here). Package Aproved
===============
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-github3py-1.0.0-0.1a4.fc24.noarch.rpm
python3-github3py-1.0.0-0.1a4.fc24.noarch.rpm
python-github3py-1.0.0-0.1a4.fc24.src.rpm
python2-github3py.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python3-github3py.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-github3py.src: W: spelling-error %description -l en_US py -> pt, p, y
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires
--------
python3-github3py (rpmlib, GLIBC filtered):
python(abi)
python3-requests
python3-uritemplate
python2-github3py (rpmlib, GLIBC filtered):
python(abi)
python2-requests
python2-uritemplate
Provides
--------
python3-github3py:
python3-github3py
python2-github3py:
python-github3
python-github3.py
python-github3py
python2-github3py
Source checksums
----------------
https://github.com/sigmavirus24/github3.py/archive/1.0.0a4/github3py-1.0.0a4.tar.gz :
CHECKSUM(SHA256) this package : 1446b972ac0e415d38e6b2d2edb774319dd61dda3fc40031a7f8a159fb2af6be
CHECKSUM(SHA256) upstream package : 1446b972ac0e415d38e6b2d2edb774319dd61dda3fc40031a7f8a159fb2af6be
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-github3py python-github3py-1.0.0-0.1a4.fc24 python-uritemplate-0.3.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d42fa6a33d python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d42fa6a33d python-github3py-1.0.0-0.1a4.fc24, python-uritemplate-0.3.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |