Bug 1351139
| Summary: | The volume option "nfs.enable-ino32" should be a per volume one, not global | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Niels de Vos <ndevos> |
| Component: | nfs | Assignee: | bugs <bugs> |
| Status: | CLOSED DEFERRED | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | low | ||
| Version: | mainline | CC: | atumball, bugs |
| Target Milestone: | --- | Keywords: | EasyFix, FutureFeature, StudentProject, Triaged |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1350851 | Environment: | |
| Last Closed: | 2019-07-05 07:27:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1350851 | ||
REVIEW: https://review.gluster.org/21674 (nfs: \"nfs.enable-ino32\" should be set per volume) posted (#1) for review on master by Harpreet Kaur Lalwani Marking as DEFERRED, to represent the current status. No one is looking at it. Can be picked up later. |
Description of problem: Volume option, "nfs.enable-ino32" behaving as a global option for all volumes instead providing a single volume for setting the volume option, [root@node1 ~]# gluster volume set test nfs.enable-ino32 on volume set: success [root@node1 ~]# gluster volume info |grep "nfs.enable-ino32" nfs.enable-ino32: on nfs.enable-ino32: on nfs.enable-ino32: on nfs.enable-ino32: on Version-Release number of selected component (if applicable): all How reproducible: Always Steps to Reproduce 1. Create a few volumes, type does not matter 2. Set the volume option, # gluster v set test nfs.enable-ino32 on Actual results: Volume option is setting as a global option for all the volume's. Expected results: Volume option should set for single volume. Additional info: The change that is needed would be similar to the "nfs.disable" option. The enable_ino32 boolean will need to move from the nfs_state structure to nfs3_state. nfs3_iatt_gfid_to_ino() can then get a 2nd argument "gf_boolean ino32". I see this as an EasyFix, a new contributor should be able to implement the changes.