Bug 1351406
| Summary: | nuke_images.sh can't remove image whose name or tag is <none> | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Anping Li <anli> |
| Component: | Cluster Version Operator | Assignee: | Devan Goodwin <dgoodwin> |
| Status: | CLOSED ERRATA | QA Contact: | Anping Li <anli> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.2.1 | CC: | aos-bugs, bleanhar, jokerman, mmccomas, tdawson |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Previously a bug in a script which cleans out all pre-existing images and containers during a Docker 1.10 upgrade would cause the script to miss some images with name and tag "none", potentially resulting in a slower or failed Docker upgrade.
This script has been updated to use a more robust method of cleanup which also catches orphaned images.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-09-27 09:39:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Anping Li
2016-06-30 03:19:53 UTC
Still can't remove image '172.30.55.28:5000/test/django-example:<none>'.
[root@host4node ~]# docker images
REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE
172.30.55.28:5000/test/django-example <none> 41948e00ba1e 47 hours ago 516.5 MB
[root@host4node ~]# sh nuke_images.sh docker
++ docker ps -q
+ running_container_ids=
+ test -n ''
++ docker ps -a -q
+ container_ids=
+ test -n ''
++ docker images -q
+ image_ids=41948e00ba1e
+ test -n 41948e00ba1e
++ docker images
++ grep '/\|/ \| \| \|-\|_'
++ awk '{print $1 ":" $2}'
+ docker rmi REPOSITORY:TAG '172.30.55.28:5000/test/django-example:<none>'
+ echo 'No images matching "" left to purge.'
No images matching "" left to purge.
This script is a real pain to get correct. The problem is quite low priority so I'm going to set this aside for now. Worst case scenario these images will get auto upgraded. Anping let me know if you have a good reproducer for getting a <none>:<none> orphaned image, I can't quite seem to do it. oc new-app cakephp-example, this command will create 172.30.55.28:5000/test/django-example:<none> I think this could be considered fixed now, however I can't fully guarantee nuke_images.sh will get everything, Docker has been quite fussy about what it will delete and sometimes just outright breaks. However the new changes arrived in: https://github.com/openshift/openshift-ansible/pull/2285 You can see all the details in there but I think the new method of clearing out images might be more reliable, and should get these none/none orphans. This should be built with openshift-ansible-3.3.10-1 so I will move to ON_QA. Verified and pass, those images with <none> tag was removed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1933 |