Bug 1351537

Summary:	[Bitrot] Need a way to set scrub interval to a minute, for ease of testing
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	bitrot	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	mainline	CC:	bugs, khiremat, mzywusko, sanandpa
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	v3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1337391
Clones:	1354425 (view as bug list)		Environment:
Last Closed:	2017-03-08 09:30:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1337391
Bug Blocks:	1354425, 1354429

Description Kotresh HR 2016-06-30 09:27:05 UTC

+++ This bug was initially created as a clone of Bug #1337391 +++

Description of problem:
========================
Currently, the command 'gluster volume bitrot <volname> scrub-frequency' can set the frequency to hourly/daily/weekly/biweekly/monthly. For testing, we set the frequency to the minimum possible, i.e., an hour. After corrupting a file,  we are forced to wait out an entire hour (or more) for the scrubber to mark the file as 'corrupted'. The above mentioned step is one of the common task that is followed for most test cases. 

This leads to unnecessary inconvenience when testing bitrot feature. Needless to say, automation also takes close to 3 days, just because of the mandatory requirement of waiting for an hour before doing any validation. I understand the need to reduce time < hour would never arise in the field, but it would be good to have such an option provided for testing and regression purposes, in the upcoming releases. 


Version-Release number of selected component (if applicable):
============================================================


Additional info:
================
[root@dhcp35-13 ~]# gluster v bitrot ozone 
Usage: volume bitrot <VOLNAME> {enable|disable} |
volume bitrot <volname> scrub-throttle {lazy|normal|aggressive} |
volume bitrot <volname> scrub-frequency {hourly|daily|weekly|biweekly|monthly} |
volume bitrot <volname> scrub {pause|resume|status}
[root@dhcp35-13 ~]#

Comment 1 Vijay Bellur 2016-06-30 09:28:16 UTC

REVIEW: http://review.gluster.org/14836 (features/bitrot: Option to set scrub interval to a minute) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 2 Vijay Bellur 2016-07-05 11:46:17 UTC

COMMIT: http://review.gluster.org/14836 committed in master by Jeff Darcy (jdarcy) 
------
commit 7df1174f7bed2a00631cf17201f5217a053afeb1
Author: Kotresh HR <khiremat>
Date:   Thu Jun 30 14:49:51 2016 +0530

    features/bitrot: Option to set scrub interval to a minute
    
    Bitrot scrub-frequency supports "hourly|daily|weekly|biweekly|monthly".
    But it is painful for testing as minimum  scrub-interval is an hour
    Hence introducing a scrub interval of minute to ease testing.
    It is intentionally not exposed in bitrot command help as it is
    only for testing.
    
    e.g.,
    gluster vol bitrot <volname> scrub-frequency minute
    
    Change-Id: I155a65298d3fad5ae9e529d9c7d4b0d25fa297c0
    BUG: 1351537
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/14836
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>