Bug 1351877

Summary:	gfapi: in case of handle based APIs, close glfd after successful create
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	libgfapi	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.12	CC:	bugs, ndevos, sdharane
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.13	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1339553	Environment:
Last Closed:	2016-07-20 13:55:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1339553
Bug Blocks:	1334907, 1350804

Description Soumya Koduri 2016-07-01 06:16:13 UTC

+++ This bug was initially created as a clone of Bug #1339553 +++

Description of problem:

In gfapi, we create and associate a (gl)fd during creation of any file. But in case of handleops, since application is interested in handle (glfs_object), this
(gl)fd is not passed to application resulting in a leak. The fix is to close it after successful create.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-25 06:02:23 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after create) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-06-02 03:24:31 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after create) posted (#2) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-06-09 03:21:06 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after create) posted (#3) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-06-27 06:12:54 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after create) posted (#4) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-06-27 07:36:10 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Avoid using glfd during create) posted (#5) for review on master by soumya k (skoduri)

--- Additional comment from Vijay Bellur on 2016-06-28 07:22:15 EDT ---

COMMIT: http://review.gluster.org/14532 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 763ed1017b0011934ad2414d7396c46e528ea5b3
Author: Soumya Koduri <skoduri>
Date:   Wed May 25 14:38:31 2016 +0530

    gfapi/handleops: Avoid using glfd during create
    
    To avoid leaking glfd while creating a file using handleops and
    since application shall not be interested in it, use the 'fd'
    object directly which can be un'refed post create.
    
    Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
    BUG: 1339553
    Signed-off-by: Soumya Koduri <skoduri>
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/14532
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Vijay Bellur 2016-07-01 06:17:41 UTC

REVIEW: http://review.gluster.org/14840 (gfapi/handleops: Avoid using glfd during create) posted (#1) for review on release-3.7 by soumya k (skoduri)

Comment 2 Vijay Bellur 2016-07-01 09:36:28 UTC

REVIEW: http://review.gluster.org/14840 (gfapi/handleops: Avoid using glfd during create) posted (#2) for review on release-3.7 by soumya k (skoduri)

Comment 3 Vijay Bellur 2016-07-01 09:41:35 UTC

REVIEW: http://review.gluster.org/14840 (gfapi/handleops: Avoid using glfd during create) posted (#3) for review on release-3.7 by soumya k (skoduri)

Comment 4 Vijay Bellur 2016-07-03 11:16:04 UTC

COMMIT: http://review.gluster.org/14840 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 851ea76c04a8139ef307070550f8b4461a819bc6
Author: Soumya Koduri <skoduri>
Date:   Wed May 25 14:38:31 2016 +0530

    gfapi/handleops: Avoid using glfd during create
    
    To avoid leaking glfd while creating a file using handleops and
    since application shall not be interested in it, use the 'fd'
    object directly which can be un'refed post create.
    
    This is backport of below mainline patch -
      http://review.gluster.org/14532
    
    > Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
    > BUG: 1339553
    > Signed-off-by: Soumya Koduri <skoduri>
    > Signed-off-by: Jiffin Tony Thottan <jthottan>
    > Reviewed-on: http://review.gluster.org/14532
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Tested-by: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    (cherry picked from commit 763ed1017b0011934ad2414d7396c46e528ea5b3)
    
    Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
    BUG: 1351877
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14840
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>

Comment 5 Kaushal 2016-07-20 13:55:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.13, please open a new bug report.

glusterfs-3.7.13 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-July/027604.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user