Bug 1352003

Summary: Plugin enable options are confusing
Product: Red Hat Satellite Reporter: Stephen Benjamin <stbenjam>
Component: InstallationAssignee: Stephen Benjamin <stbenjam>
Status: CLOSED ERRATA QA Contact: Renzo Nuccitelli <rnuccite>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, lpramuk, rnuccite, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-21 16:51:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
6.2.4 installer options
none
6.3.0 snap 6 installer options none

Description Stephen Benjamin 2016-07-01 11:28:54 UTC
Every plugin has 2 options like this:

<pre>
    --[no-]enable-foreman-plugin-remote-execution Enable 'foreman_plugin_remote_execution' puppet module (default: false)
    --foreman-proxy-plugin-remote-execution-ssh-enabled  Enables/disables the plugin (default: true)
</pre>

The former is really the one to use to actually enabling the plugin, the latter only triggers the .yml config enable option.

It's very confusing for end users who probably see the second option first as it's near the end of the --help.

Comment 1 Stephen Benjamin 2016-07-01 11:28:58 UTC
Created from redmine issue http://projects.theforeman.org/issues/15556

Comment 3 Bryan Kearney 2016-07-01 22:16:17 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/15556 has been closed

Comment 4 Stephen Benjamin 2016-08-01 18:49:12 UTC
*** Bug 1359816 has been marked as a duplicate of this bug. ***

Comment 7 Renzo Nuccitelli 2016-11-15 11:36:05 UTC
Created attachment 1220805 [details]
6.2.4 installer options

Comment 8 Renzo Nuccitelli 2016-11-15 11:36:51 UTC
Created attachment 1220806 [details]
6.3.0 snap 6 installer options

Comment 9 Renzo Nuccitelli 2016-11-15 11:39:57 UTC
I have uploaded as attachments the cli commands to verifying installer options on both version 6.2.4 and 6.3.0 snap 6. Here is the diff between files:

[renzo@note Documents]$ diff sat63-plugin-options sat62-plugin-options 
1,3c1,3
< [root@foo ~]# rpm -q satellite
< satellite-6.3.0-6.1.beta.el7sat.noarch
< [root@foo ~]# satellite-installer --help | grep plugin-remote-execution
---
> [root@bar ~]# rpm -q satellite
> satellite-6.2.4-1.0.el7sat.noarch
> [root@bar ~]# satellite-installer --help | grep plugin-remote-execution
5a6
>     --foreman-proxy-plugin-remote-execution-ssh-enabled  Enables/disables the plugin (default: true)
6a8
>     --foreman-proxy-plugin-remote-execution-ssh-listen-on  Proxy feature listens on https, http, or both (default: "https")
[renzo@note Documents]$ 

Once --foreman-proxy-plugin-remote-execution-ssh-enabled is not present on 6.3.0 snap 6 anymore I am changing the status of this bug to verified.

Comment 11 Satellite Program 2018-02-21 16:51:07 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
> 
> For information on the advisory, and where to find the updated files, follow the link below.
> 
> If the solution does not work for you, open a new bug report.
> 
> https://access.redhat.com/errata/RHSA-2018:0336