Bug 1352020

Summary: freemedforms 0.9.4-5 not built with $RPM_OPT_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: freemedformsAssignee: Ankur Sinha (FranciscoD) <sanjay.ankur>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mrceresa, nobrakal, rdieter, sanjay.ankur, thinklinux.ssh
Target Milestone: ---Keywords: EasyFix, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: freemedforms-0.9.4-6.fc24 freemedforms-0.9.4-6.fc23 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-10 05:54:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968, 1279265    

Description Ville Skyttä 2016-07-01 12:19:28 UTC
freemedforms 0.9.4-5 is not built with $RPM_OPT_FLAGS. The build invokes qmake directly, it should probably use an appropriate macro instead.

https://lists.fedoraproject.org/archives/list/devel%40lists.fedoraproject.org/message/6TLCJFMMVPYHJKDL4XZYUEO66GYM64I7/

Comment 1 Rex Dieter 2016-07-01 23:48:38 UTC
I can confirm this is enough to fix it:

diff --git a/freemedforms.spec b/freemedforms.spec
index 1b62d53..1c444cf 100644
--- a/freemedforms.spec
+++ b/freemedforms.spec
@@ -189,7 +189,7 @@ lrelease global_resources/translations/*.ts
 pushd freemedforms
             # Plugin broken. Disabled at the moment. Upstream is aware.
             #"CONFIG+=with-webcam" \
-    qmake freemedforms.pro -r \
+    %{qmake_qt4} freemedforms.pro -r \
             "CONFIG+=release" "CONFIG-=debug" \
             "CONFIG+=LINUX_INTEGRATED" "CONFIG+=dontbuildquazip" \
             "CONFIG+=with-plugin" "CONFIG+=with-account" \

Comment 2 Ville Skyttä 2016-07-02 06:07:09 UTC
Note that there are two qmake invocations in the specfile, one for freemedforms.pro and another for freediams.pro; I guess both need the change.

Comment 3 Ankur Sinha (FranciscoD) 2016-07-04 07:48:27 UTC
Ack. Working on this now.

Comment 4 Fedora Update System 2016-07-04 13:44:53 UTC
freemedforms-0.9.4-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ec02aaec63

Comment 5 Fedora Update System 2016-07-04 13:45:01 UTC
freemedforms-0.9.4-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d47c8bb57f

Comment 6 Fedora Update System 2016-07-05 08:52:50 UTC
freemedforms-0.9.4-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d47c8bb57f

Comment 7 Fedora Update System 2016-07-05 15:24:18 UTC
freemedforms-0.9.4-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ec02aaec63

Comment 8 Fedora Update System 2016-07-10 05:54:21 UTC
freemedforms-0.9.4-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-07-14 00:23:00 UTC
freemedforms-0.9.4-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.