Bug 1352042

Summary:	Review Request: perl-Specio - Type constraints and coercions for Perl
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-01 16:27:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Howarth 2016-07-01 13:23:17 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Specio/branches/fedora/perl-Specio.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Specio/perl-Specio-0.24-2.fc25.src.rpm

Description:
The Specio distribution provides classes for representing type constraints
and coercion, along with syntax sugar for declaring them.

Note that this is not a proper type system for Perl. Nothing in this
distribution will magically make the Perl interpreter start checking a value's
type on assignment to a variable. In fact, there's no built-in way to apply a
type to a variable at all.

Instead, you can explicitly check a value against a type, and optionally coerce
values to that type.

Fedora Account System Username: pghmcfc

Note: upstream for perl-DateTime is currently trialling using this (and Params::CheckCompiler) in place of Params::Validate.

Comment 1 Jitka Plesnikova 2016-07-22 10:31:08 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Specio-0.24-2.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(B)
      1 perl(Carp)
      1 perl(Devel::StackTrace)
      1 perl(Eval::Closure)
      1 perl(Exporter)
      1 perl(List::Util) >= 1.33
      1 perl(MRO::Compat)
      1 perl(Role::Tiny)
      1 perl(Role::Tiny::With)
      1 perl(Scalar::Util)
      1 perl(Specio::Coercion)
      1 perl(Specio::Constraint::Parameterizable)
      1 perl(Specio::Constraint::Parameterized)
      1 perl(Specio::Constraint::Role::CanType)
      1 perl(Specio::Constraint::Role::DoesType)
      1 perl(Specio::Constraint::Role::Interface)
      1 perl(Specio::Constraint::Role::IsaType)
      1 perl(Specio::Constraint::Simple)
      1 perl(Specio::Declare)
      1 perl(Specio::DeclaredAt)
      1 perl(Specio::Exception)
      1 perl(Specio::Exporter)
      1 perl(Specio::Helpers)
      1 perl(Specio::Library::Builtins)
      1 perl(Specio::Library::String)
      1 perl(Specio::OO)
      1 perl(Specio::PartialDump)
      1 perl(Specio::Registry)
      1 perl(Specio::Role::Inlinable)
      1 perl(Specio::TypeChecks)
      1 perl(Storable)
      1 perl(overload)
      1 perl(parent)
      1 perl(re)
      1 perl(strict)
      1 perl(version) >= 0.83
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Specio-0.24-2.fc25.noarch.rpm | sort | uniq -c
      1 perl(Specio) = 0.24
      1 perl(Specio::Coercion) = 0.24
      1 perl(Specio::Constraint::AnyCan) = 0.24
      1 perl(Specio::Constraint::AnyDoes) = 0.24
      1 perl(Specio::Constraint::AnyIsa) = 0.24
      1 perl(Specio::Constraint::Enum) = 0.24
      1 perl(Specio::Constraint::Intersection) = 0.24
      1 perl(Specio::Constraint::ObjectCan) = 0.24
      1 perl(Specio::Constraint::ObjectDoes) = 0.24
      1 perl(Specio::Constraint::ObjectIsa) = 0.24
      1 perl(Specio::Constraint::Parameterizable) = 0.24
      1 perl(Specio::Constraint::Parameterized) = 0.24
      1 perl(Specio::Constraint::Role::CanType) = 0.24
      1 perl(Specio::Constraint::Role::DoesType) = 0.24
      1 perl(Specio::Constraint::Role::Interface) = 0.24
      1 perl(Specio::Constraint::Role::IsaType) = 0.24
      1 perl(Specio::Constraint::Simple) = 0.24
      1 perl(Specio::Constraint::Union) = 0.24
      1 perl(Specio::Declare) = 0.24
      1 perl(Specio::DeclaredAt) = 0.24
      1 perl(Specio::Exception) = 0.24
      1 perl(Specio::Exporter) = 0.24
      1 perl(Specio::Helpers) = 0.24
      1 perl(Specio::Library::Builtins) = 0.24
      1 perl(Specio::Library::Numeric) = 0.24
      1 perl(Specio::Library::Perl) = 0.24
      1 perl(Specio::Library::String) = 0.24
      1 perl(Specio::OO) = 0.24
      1 perl(Specio::PartialDump) = 0.24
      1 perl(Specio::Registry) = 0.24
      1 perl(Specio::Role::Inlinable) = 0.24
      1 perl(Specio::TypeChecks) = 0.24
      1 perl-Specio = 0.24-2.fc25
Binary provides are Ok.

$ rpmlint ./perl-Specio*
perl-Specio.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s
perl-Specio.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok


The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-07-22 13:13:57 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Specio

Comment 3 Fedora Update System 2016-07-23 13:35:29 UTC

perl-Specio-0.24-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-81706dac20

Comment 4 Fedora Update System 2016-07-23 22:21:33 UTC

perl-Specio-0.24-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-81706dac20

Comment 5 Fedora Update System 2016-08-01 16:27:08 UTC

perl-Specio-0.24-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.