Bug 1352115

Summary:	Can not change vxlan port number to anything other than default (4789)
Product:	Red Hat OpenStack	Reporter:	Jeremy <jmelvin>
Component:	openstack-puppet-modules	Assignee:	Jason Guiditta <jguiditt>
Status:	CLOSED ERRATA	QA Contact:	Alexander Stafeyev <astafeye>
Severity:	high	Docs Contact:
Priority:	high
Version:	8.0 (Liberty)	CC:	amuller, beagles, chrisw, dhill, jguiditt, jmelvin, nyechiel, ohochman, srevivo
Target Milestone:	---	Keywords:	Rebase, ZStream
Target Release:	8.0 (Liberty)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-puppet-modules-7.1.3-1.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1354598 (view as bug list)		Environment:
Last Closed:	2016-08-17 11:39:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy 2016-07-01 16:02:26 UTC

Description of problem:Can not change vxlan port number to anything other than default (4789)

The logic seems to be wrong in the code:https://github.com/redhat-openstack/openstack-puppet-modules/blob/stable/liberty/neutron/lib/puppet/parser/functions/validate_vxlan_udp_port.rb

 i believe it should be :

if value != 4789 and (49151 >= value or value > 65535)
      raise Puppet::Error, "vxlan udp port is invalid."



How reproducible:
100%

Steps to Reproduce:
1.change vxlan port
2.note error
3.

Actual results:
error

Expected results:
ability to change default port


Additional info:

Comment 1 Assaf Muller 2016-07-01 16:34:29 UTC

Reassigning to the openstack neutron puppet modules.

Comment 2 David Hill 2016-07-04 18:29:11 UTC

I believe this check should be removed unless we really can't assign vxlan ports on the higher port and keep only the > 65535 and add = 0 ...

Comment 3 Jeremy 2016-07-05 13:27:59 UTC

Current package levels:
[root heat-admin]# rpm -qa |grep neutron
openstack-neutron-common-7.0.1-15.el7ost.noarch
openstack-neutron-bigswitch-lldp-2015.3.8-1.el7ost.noarch
python-neutron-lbaas-7.0.0-2.el7ost.noarch
openstack-neutron-7.0.1-15.el7ost.noarch
openstack-neutron-openvswitch-7.0.1-15.el7ost.noarch
openstack-neutron-metering-agent-7.0.1-15.el7ost.noarch
python-neutron-7.0.1-15.el7ost.noarch
openstack-neutron-bigswitch-agent-2015.3.8-1.el7ost.noarch
openstack-neutron-lbaas-7.0.0-2.el7ost.noarch
openstack-neutron-ml2-7.0.1-15.el7ost.noarch
python-neutronclient-3.1.0-1.el7ost.noarch

Comment 4 Jason Guiditta 2016-07-11 16:22:19 UTC

Merged upstream

Comment 6 Alexander Stafeyev 2016-08-04 10:55:30 UTC

[root@vmdevstack ~(keystone_admin)]# rpm -qa | grep puppet
openstack-packstack-puppet-7.0.0-0.19.dev1702.g490e674.el7ost.noarch
puppet-3.6.2-2.el7.noarch
o




[root@vmdevstack ~(keystone_admin)]# grep -i -r "if value != 4789" /usr/
/usr/share/openstack-puppet/modules/neutron/lib/puppet/parser/functions/validate_vxlan_udp_port.rb:    if value != 4789 and (49151 >= value or value > 65535)


[root@vmdevstack ~(keystone_admin)]# grep -i -r "vxlan_udp_port" /etc/neutron/*
/etc/neutron/plugins/ml2/openvswitch_agent.ini:# vxlan_udp_port =
/etc/neutron/plugins/ml2/openvswitch_agent.ini:vxlan_udp_port =4780
/etc/neutron/plugins/ml2/openvswitch_agent.ini:# Example: vxlan_udp_port = 8472


I changed the config successfully. 

If the info above is enough then the bug can be verified. 

If the reproduction should be trying to install osp with packstack with the new value , pls let me know .

Comment 7 Alexander Stafeyev 2016-08-04 11:18:38 UTC

Changed udp port to 4444 and tryed to install. 


pplying 192.168.1.18_neutron.pp
192.168.1.18_neutron.pp:                          [ ERROR ]        
Applying Puppet manifests                         [ ERROR ]

ERROR : Error appeared during Puppet run: 192.168.1.18_neutron.pp
Error: vxlan udp port is invalid. on node vmdevstack.novalocal


pls advise

Comment 8 Jason Guiditta 2016-08-04 12:56:53 UTC

(In reply to Alexander Stafeyev from comment #7)
> Changed udp port to 4444 and tryed to install. 
> 
> 
> pplying 192.168.1.18_neutron.pp
> 192.168.1.18_neutron.pp:                          [ ERROR ]        
> Applying Puppet manifests                         [ ERROR ]
> 
> ERROR : Error appeared during Puppet run: 192.168.1.18_neutron.pp
> Error: vxlan udp port is invalid. on node vmdevstack.novalocal
> 
> 
> pls advise

I replied on the mitaka version of the bug[1] before I saw this, let me know if that makes sense.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1354598

Comment 10 Alexander Stafeyev 2016-08-07 03:29:18 UTC

[root@vmdevstack ~]# rpm -qa | grep puppet
openstack-puppet-modules-7.1.3-1.el7ost.noarch

Configured port to 49152 and the installation passed well

Finalizing                                           [ DONE ]

 **** Installation completed successfully ******

Comment 12 errata-xmlrpc 2016-08-17 11:39:00 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1619.html