Bug 135223

Summary: [PATCH] Don't use libuser entity objects for dict indexing
Product: [Fedora] Fedora Reporter: Miloslav Trmač <mitr>
Component: system-config-usersAssignee: Nils Philippsen <nphilipp>
Status: CLOSED RAWHIDE QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-10-10 22:50:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
s/]/Name]/ in a few places none

Description Miloslav Trmač 2004-10-10 22:05:08 UTC 
Hello Nils,
While researching bug 113730 I have noticed that libuser entity
names are sometimes used instead of entity names for dict indexing;
the attached patch should clean that up (and also halve the number
of libuser entities needed, although that is unrelated to the
leaks reported in bug 113730).

Another note: the lookupUserByName and lookupGroupByName calls
quoted in the patch should not be necessary because 'user'
and 'group', respectively, already are libuser entities.
Comment 1 Miloslav Trmač 2004-10-10 22:06:37 UTC 
Created attachment 104993 [details]
s/]/Name]/ in a few places
Comment 2 Nils Philippsen 2004-10-10 22:50:51 UTC 
Thanks! I've added your changes and removed the excessive lookups of
user/groups as well, the fixes are in system-config-users-1.2.24-1. Do
you need these in a RHEL3 package as well?
Comment 3 Miloslav Trmač 2004-10-11 07:26:21 UTC 
From my point of view these are just code cleanups, unrelated
to bug 113730.