Bug 135235

Summary:	ifup-wireless multiple WEP key support broke open vs restricted WEP
Product:	[Fedora] Fedora	Reporter:	Dax Kelson <dkelson>
Component:	initscripts	Assignee:	Bill Nottingham <notting>
Status:	CLOSED RAWHIDE	QA Contact:	Brock Organ <borgan>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	rvokal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-10-11 14:36:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dax Kelson 2004-10-11 06:21:23 UTC

Description of problem:

When the patch for multiple WEP keys in ifup-wireless was added,
support for specifying "open" vs "restricted" WEP was broken (which
has worked for many years).

WEP can work in two modes, 'open' or 'restricted'. Despite the name,
'open' is more secure. Many APs only allow 'open'. Most Linux wireless
drivers default to 'restricted'. :(

For many years you could specify what type of WEP you wanted by having
your ifcfg-ethX or keys-ethX have the line:

KEY="open your-key-goes-here"
or
KEY="restricted your-key-goes-here"

When support for multiple WEP keys was added (bug: 127340, bug:
127957) the logic was changed in ifup-wireless and broke the
open/restricted handling for "KEY" (but ironically, not for KEY1,KEY2,
KEY3,KEY4).

The fix is very simple, please add for FC3/RHEL4:

--- ifup-wireless.broken        2004-10-11 00:18:34.283463488 -0600
+++ ifup-wireless       2004-10-11 00:18:46.561596928 -0600
@@ -59,7 +59,7 @@
     [ -n "$KEY3" ] && iwconfig $DEVICE key [3] $KEY3
     [ -n "$KEY4" ] && iwconfig $DEVICE key [4] $KEY4
     [ -n "$DEFAULTKEY" ] && iwconfig $DEVICE key [${DEFAULTKEY}]
-    [ -n "$KEY" ] && iwconfig $DEVICE key "$KEY"
+    [ -n "$KEY" ] && iwconfig $DEVICE key $KEY
 else
     iwconfig $DEVICE key off
 fi

Comment 1 Bill Nottingham 2004-10-11 14:36:47 UTC

Added in CVS, will be in future builds, thanks!