Bug 1352996 (python-zipstream)

Summary:	Review Request: python-zipstream - ZIP archive generator for Python
Product:	[Fedora] Fedora	Reporter:	Othman Madjoudj <athmanem>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ignatenko, package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-11 21:59:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1353000

Description Othman Madjoudj 2016-07-05 17:37:13 UTC

Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-1.fc24.src.rpm
Description:
zipstream.py is a zip archive generator based on python 3.3's zipfile.py.
It was created to generate a zip file generator for streaming (ie web apps)

Fedora Account System Username: athmane

Comment 1 Othman Madjoudj 2016-07-07 12:40:49 UTC

New SPEC/SRPMS:

Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-2.fc24.src.rpm

Comment 2 Igor Gnatenko 2016-07-07 12:49:26 UTC

> %global sum A zip archive generator for Python
drop this line

> Name:           python-zipstream
Name: python-%{srcname}

> Summary:        A zip archive generator for Python
Summary: ZIP archive generator for Python

> License:        GPLv3
License: GPLv3+

> URL:            https://github.com/allanlei/python-zipstream
URL: https://github.com/allanlei/%{name}

> Source0:        https://github.com/allanlei/python-zipstream/archive/v%{version}.tar.gz
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

> BuildRequires:  python3-devel python-devel
Drop this lines

> %package -n python2-%{srcname}
> Summary:        %{sum}
Summary: %{summary}
BuildRequires: python2-devel
> %description -n python2-%{srcname}
> %{desc}
Python 2 version.

... same for python3 ...

> %autosetup -n %{name}-%{version}
%autosetup

> nosetests-%{python2_version} -v
Why not %{__python2} setup.py test?

... same for python3 ...

Comment 3 Igor Gnatenko 2016-07-07 12:51:16 UTC

Ah, also missing BuildRequires: pythonX-setuptools

Comment 4 Othman Madjoudj 2016-07-07 14:28:54 UTC

Thanks for reviewing, bellow the updated SPEC/SRPM:

Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-3.fc24.src.rpm

Comment 5 Igor Gnatenko 2016-07-07 14:32:55 UTC

python-setuptools -> python2-setuptools
python-nose -> python2-nose

also move BuildRequires under python2/python3 subpackages

> %autosetup -n %{name}-%{version}
still not fixed. remove "-n %{name}-%{version}

%{desc} should be with "." in the end.

Comment 6 Othman Madjoudj 2016-07-07 14:53:58 UTC

Fix.

Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-4.fc24.src.rpm

Comment 7 Igor Gnatenko 2016-07-07 14:56:03 UTC

Everything is according to packaging guidelines.

APPROVED.

Comment 8 Gwyn Ciesla 2016-07-08 14:29:08 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-zipstream

Comment 9 Othman Madjoudj 2016-07-11 21:59:44 UTC

Built in rawhide and f24, I forgot to add the bug # to the update, now it's locked :P