Bug 1353216

Summary: terminal prompt containing "notify;command completed"
Product: [Fedora] Fedora Reporter: Kai Engert (:kaie) (inactive account) <kengert>
Component: vte291Assignee: Debarshi Ray <debarshir>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: debarshir, fgrose, kevin, klember, pbrobinson, redhat-bz, satellitgo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-08 15:25:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kai Engert (:kaie) (inactive account) 2016-07-06 14:40:00 UTC
Using xfce4-terminal on Fedora 24, which apparently uses VTE, every prompt is preceeded by the following text:

ESC]777;notify;Command completed;exportESC]7;file://lapkaie/home/kaie

This seems related:
https://github.com/fish-shell/fish-shell/issues/2102
https://github.com/fish-shell/fish-shell/pull/2096#issuecomment-107107684

So apparently, the project implemented some kind of notification mechanism, which gets triggered after a command is complete, but instead of handling this notification behind the scene, xfce4-terminal instead displays it as text.

Which software is responsible for handling this better, is it VTE or xfce4-terminal?

Is it possible by configuration to disable that display?

Thanks

Comment 1 satellitgo 2016-07-06 14:47:54 UTC
Fedora-SoaS-Live-x86_64-Rawhide-20160704.n.0.iso

In terminal application in soas:

777;notify;Command completed;[user@localhost ~]$

Comment 2 Kevin Fenzi 2016-07-06 15:24:10 UTC
This is not xfce4-terminals fault, and I cannot duplicate it here. ;( 

There's two places this prompt could be getting set: 

/etc/bashrc -> bash package
/etc/profile.d/vte.sh -> vte-profile (subpackage of vte291)

I'm not sure which one is doing this to your prompt incorrectly. 

Does 'echo $VTE_VERSION' return anyting?

I'll move this over to vte291 for further comment/debugging.

Comment 3 Kai Engert (:kaie) (inactive account) 2016-07-06 15:29:06 UTC
The bug appears to be related to the selected XFCE theme.

Using xfce4-settings-manager, appearance, I've switched between themes, and currently the bug is gone.

Even using a theme that I had previously selected, I no longer can reproduce.

Maybe this bug depends on old system config, carried over from previous installs (after ugprading)?

Comment 4 Kai Engert (:kaie) (inactive account) 2016-07-06 15:31:48 UTC
... although I had previously switched between themes, which didn't cause the issue to go away.

However, in the meantime I have installed the numix-gtk-theme, which is apparently the only Gtk 3.2 theme I have.

Could enabling this theme once have had a healing effect?

Comment 5 Kai Engert (:kaie) (inactive account) 2016-07-06 15:32:14 UTC
Other things I did in the meantime, I had installed "terminator" and "terminology" with their dependencies.

Comment 6 Kalev Lember 2016-07-06 16:10:07 UTC
Looks like a fallout from vte291 notification patches

Comment 7 Debarshi Ray 2016-07-07 15:00:22 UTC
Fedora's vte291 [1] offers a notification-received signal on the VteTerminal widget. The idea is that terminal applications can connect to this signal and do something appropriate with it. eg., they can send a desktop-wide notification or they can somehow flag the appropriate tab with an in-app notification. See Fedora's gnome-terminal [2] for an example.

Note that VteTerminal won't send any desktop notifications by itself. But it does rely on PROMPT_COMMAND to be set in a particular way for the notification mechanism (via escape sequences) to work as expected.

How does PROMPT_COMMAND look on your system?

[1] https://github.com/debarshiray/vte/tree/vte-0-44-ntfy
[2] https://github.com/debarshiray/gnome-terminal/tree/gnome-3-20-ntfy-ts

Comment 8 Debarshi Ray 2016-07-07 16:57:04 UTC
(In reply to Kai Engert (:kaie) from comment #0)
> Using xfce4-terminal on Fedora 24, which apparently uses VTE, every prompt
> is preceeded by the following text:
> 
> ESC]777;notify;Command completed;exportESC]7;file://lapkaie/home/kaie

Sorry, I misread the bug report. I didn't realize that you were complaining about this string appearing in front of every prompt in the terminal. Instead, I interpreted it as some garbled desktop notification showing up, which didn't seem to make sense.

Sorry about that.

> This seems related:
> https://github.com/fish-shell/fish-shell/issues/2102

As I commented there, starting from version 0.44.2 (ie. vte291-0.44.2 in Fedora) it will silently accept the OSC 777 escape sequence as a no-op without printing anything in the terminal.

However, xfce4-terminal uses a much older vte ABI (ie. vte-0.28.2) that uses gtk2.

If you look at /etc/profile.d/vte.sh, which is where PROMPT_COMMAND is set up to emit the OSC 777 escape sequence, you will notice that it should only do so for newer versions. ie. "${VTE_VERSION:-0}" -ge 3405. That's why neither Kevin nor I can reproduce this with xfce4-terminal.

So, I am wondering whether this was actually seen with xfce4-terminal. Or was it some other application?

Also which versions of vte did you have:
$ rpm -q vte vte3 vte291

(Yes, the vte naming/versioning is insane, but I didn't come up with it.)

Comment 9 Debarshi Ray 2016-07-07 17:00:29 UTC
(In reply to Debarshi Ray from comment #8)
> (In reply to Kai Engert (:kaie) from comment #0)
> > This seems related:
> > https://github.com/fish-shell/fish-shell/issues/2102
> 
> As I commented there, starting from version 0.44.2 (ie. vte291-0.44.2 in
> Fedora) it will silently accept the OSC 777 escape sequence as a no-op
> without printing anything in the terminal.

On hindsight, I realize that this can be confusing.

It means that irrespective of whether you have the Fedora patches to handle OSC 777, you should not see the escape sequence being printed in the terminal. If you have the patches, then it won't be a no-op but it will handle OSC 777 by emitting the VteTerminal::notification-received signal.

Comment 10 Kai Engert (:kaie) (inactive account) 2016-07-07 17:05:01 UTC
satellitgo: Could you answer the question about the versions that produces the notify message in the prompt.

I cannot reproduce any longer.

Comment 11 Robert 2017-04-28 17:46:04 UTC
I just ran into this today after updating my Fedora 25 installation. Is there a preferred workaround?

My observations:
* PROMPT_COMMAND="__vte_prompt_command"
* after a time-consuming command (on unsetting PROMPT_COMMAND), the noise goes away
* sometimes, a simple command (or... output?) will cause the terminal to "flicker" horribly... like thrashing between two unstable states
* there is a vte package labelled as "fedora-24", but was not previously an issue

$ rpm -qa | grep vte
vte-profile-0.46.1-1.fc25.x86_64
evtest-1.33-2.fc24.x86_64
vte-0.28.2-18.fc25.x86_64
vte291-0.46.1-1.fc25.x86_64
vte3-0.36.5-2.fc24.x86_64 <--- (!?)

Package change set that introduced this issue, I've trimmed out a few that I'm 99% sure are irrelevant:

-0:gtk3-3.22.11-1.fc25.x86_64
+0:gtk3-3.22.12-2.fc25.x86_64
-0:gtk3-devel-3.22.11-1.fc25.x86_64
+0:gtk3-devel-3.22.12-2.fc25.x86_64
-0:gtk3-immodule-xim-3.22.11-1.fc25.x86_64
+0:gtk3-immodule-xim-3.22.12-2.fc25.x86_64
-0:gtk-update-icon-cache-3.22.11-1.fc25.x86_64
+0:gtk-update-icon-cache-3.22.12-2.fc25.x86_64
+0:kernel-4.10.12-200.fc25.x86_64
+0:kernel-core-4.10.12-200.fc25.x86_64
-0:kernel-devel-4.8.12-300.ck8.hu.1.fc25.x86_64
+0:kernel-devel-4.10.12-200.fc25.x86_64
-0:kernel-headers-4.10.11-200.fc25.x86_64
+0:kernel-headers-4.10.12-200.fc25.x86_64
+0:kernel-modules-4.10.12-200.fc25.x86_64
+0:kernel-modules-extra-4.10.12-200.fc25.x86_64
-0:kernel-tools-4.10.11-200.fc25.x86_64
+0:kernel-tools-4.10.12-200.fc25.x86_64
-0:kernel-tools-libs-4.10.11-200.fc25.x86_64
+0:kernel-tools-libs-4.10.12-200.fc25.x86_64
-0:perl-Mojolicious-7.23-1.fc25.noarch
+0:perl-Mojolicious-7.30-1.fc25.noarch
-0:python3-3.5.3-4.fc25.x86_64
+0:python3-3.5.3-5.fc25.x86_64
-0:python3-jedi-0.10.0-1.fc25.noarch
+0:python3-jedi-0.10.2-1.fc25.noarch
-0:python3-libs-3.5.3-4.fc25.x86_64
+0:python3-libs-3.5.3-5.fc25.x86_64
-0:python-perf-4.10.11-200.fc25.x86_64
+0:python-perf-4.10.12-200.fc25.x86_64
-0:rsyslog-8.25.0-2.fc25.x86_64
+0:rsyslog-8.26.0-1.fc25.x86_64
-0:system-python-3.5.3-4.fc25.x86_64
+0:system-python-3.5.3-5.fc25.x86_64
-0:system-python-libs-3.5.3-4.fc25.x86_64
+0:system-python-libs-3.5.3-5.fc25.x86_64
-0:xfwm4-4.12.3-3.fc24.x86_64
-0:xfwm4-4.12.3-3.fc24.x86_64
+0:xfwm4-4.12.4-1.fc25.x86_64
-1:emacs-filesystem-25.1-3.fc25.noarch
+1:emacs-filesystem-25.2-1.fc25.noarch
-2:vim-common-8.0.562-1.fc25.x86_64
+2:vim-common-8.0.586-1.fc25.x86_64
-2:vim-enhanced-8.0.562-1.fc25.x86_64
+2:vim-enhanced-8.0.586-1.fc25.x86_64
-2:vim-filesystem-8.0.562-1.fc25.x86_64
+2:vim-filesystem-8.0.586-1.fc25.x86_64
-2:vim-minimal-8.0.562-1.fc25.x86_64
+2:vim-minimal-8.0.586-1.fc25.x86_64

Comment 12 Fedora End Of Life 2017-07-25 21:38:02 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 13 Fedora End Of Life 2017-08-08 15:25:05 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 14 Frederick Grose 2017-11-03 00:47:01 UTC
This continues to be a problem in Fedora-SoaS-Live-x86_64-27-1.2.iso, which contains vte3-0.36.5-5.fc27.x86_64

Comment 15 Debarshi Ray 2017-11-03 12:39:40 UTC
(In reply to Frederick Grose from comment #14)
> This continues to be a problem in Fedora-SoaS-Live-x86_64-27-1.2.iso, which
> contains vte3-0.36.5-5.fc27.x86_64

vte3 is an older ABI of the VteTerminal widget, and the package has been kept around for compatibility. I ported a few users to the newer ABI, but I don't think I covered all of them. FWIW, the newer ABI is in the vte291 package. (Strange choice of name, I know. :)

The older vte3 is unaware of the notification mechanism (comment 7 onwards), so I am not surprised that this is happening. Question is, what's still using vte3 on that ISO? Can it be switched to the newer ABI?

Comment 16 Frederick Grose 2017-11-03 14:40:53 UTC
Fedora-SoaS contains sugar-terminal-45.1-2.fc27, https://koji.fedoraproject.org/koji/buildinfo?buildID=932850
Repository at https://github.com/sugarlabs/terminal-activity

Also present is vte-profile-0.50.1-1.fc27.x86_64

I'm uncertain how vte3-0.36.5-5.fc27.x86_64 got installed.

See https://bugzilla.redhat.com/show_bug.cgi?id=1220006

Comment 17 Robert 2017-11-03 15:16:10 UTC
I had this crop up again for me.

I imagine that it has something to do with a major-version upgrade; e.g. a package that is dropped from the repo (but still installed), some /etc/default lines in .bashrc that are no longer put there, etc.

Otherwise, it could be an oversight from assuming a gnome-session; as the two machines I saw this on were xfce & kwin.

As I recall (i.e. don't count on it), I tried to remove the package that contained the offending profile-noise, and it wanted to remove half the system, so I just truncated the files, or something.