Bug 1353219

Description of problem:
If there is a snapshot with memory that exists in the system such that the memory resides in a storage domain that was removed from the system later on (meaning it doesn't exists in the database anymore), one of the upgrade scripts fails.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a snapshot with memory in 3.6
2. Remove the storage domain that the memory resides in
3. Upgrade to 4.0

Actual results:
Failure:
 insert or update on table "image_storage_domain_map" violates foreign
 key constraint
 "fk_image_storage_domain_map_storage_domain_static"
 DETAIL:  Key (storage_domain_id)=(006552b0-cae3-4ccb-9baa-ee8c3b8e42cf)
 is not present in table "storage_domain_static".
 FATAL: Cannot execute sql command:
 --file=/usr/share/ovirt engine/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql

Expected results:
Upgrade should succeed

Additional info:
Setting priority to high as there is a workaround that was confirmed to work:
use the following query to identify the exact problematic snapshots and remove them before upgrading:
select vm_name, snapshots.description as snapshot_name, snapshot_id from snapshots join vm_static on vm_id=vm_guid where CAST(split_part(memory_volume, ',', 1) AS UUID) not in (select id from storage_domain_static);