Bug 1353473

Summary: rubygem-sprockets: Enable closure-compiler test suite
Product: [Fedora] Fedora Reporter: Jun Aruga <jaruga>
Component: rubygem-sprocketsAssignee: Vít Ondruch <vondruch>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: pvalena, strzibny, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-01 12:55:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jun Aruga 2016-07-07 08:46:38 UTC 
Description of problem:
rubygem-sprockets depends on rubygem-closure-compiler actually.
However the sprockets uses a constant variable: Autoload::Closure::COMPILER_VERSION [1] in the closure-compiler logic.
And it variable is disabled in the rubygem-closure-compiler spec file. [2]
Because of the reason, we can not enable the closure-compiler, and the test case.

[1] https://github.com/rails/sprockets/blob/v3.6.3/lib/sprockets/closure_compressor.rb#L39
[2] http://pkgs.fedoraproject.org/cgit/rpms/rubygem-closure-compiler.git/tree/rubygem-closure-compiler.spec?id=97499b03881e52443817aeb78c5473f8cdb8d324 L51

Version-Release number of selected component (if applicable):
3.6.3


How reproducible:

Steps to Reproduce:
1. Add "BuildRequires: rubygem(closure-compiler)" to rubygem-sprockets.spec.
2. Comment out rubygem(closure-compiler) disabled logic in the spec file.
3. Run mock build. $ mock -r fedora-rawhide-x86_64 rubygem-sprockets-3.6.3-1.fc25.src.rpm

Actual results:

  1) Error:
TestClosureCompressor#test_compress_javascript:
NameError: uninitialized constant Closure::COMPILER_VERSION
Did you mean?  Closure::COMPILER_JAR
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:39:in `initialize'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:24:in `new'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:24:in `instance'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:28:in `call'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/test/test_closure_compressor.rb:14:in `test_compress_javascript'


  2) Error:
TestClosureCompressor#test_cache_key:
NameError: uninitialized constant Closure::COMPILER_VERSION
Did you mean?  Closure::COMPILER_JAR
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:39:in `initialize'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:24:in `new'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:24:in `instance'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/lib/sprockets/closure_compressor.rb:32:in `cache_key'
    /builddir/build/BUILD/rubygem-sprockets-3.6.3/usr/share/gems/gems/sprockets-3.6.3/test/test_closure_compressor.rb:21:in `test_cache_key'

787 runs, 3413 assertions, 0 failures, 2 errors, 1 skips


Expected results:
The test is succeeded.


Additional info:
Comment 1 Jun Aruga 2016-07-07 09:56:38 UTC 
I reported upstream for closure-comipler gem pacakge to have the option to use system version closure-compiler.
https://github.com/documentcloud/closure-compiler/issues/39
Comment 2 Jan Kurik 2016-07-26 05:10:56 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.
Comment 3 Fedora End Of Life 2017-11-16 19:23:38 UTC 
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Comment 4 Vít Ondruch 2017-11-20 13:10:16 UTC 
This is very likely still an issue
Comment 5 Fedora End Of Life 2018-02-20 15:23:01 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.
Comment 6 Pavel Valena 2018-06-27 13:10:19 UTC 
The problem still persists with:
  rubygem-closure-compiler-0:1.1.12-2.fc26.noarch
  rubygem-sprockets-3.7.2-1.fc29
Comment 7 Jan Kurik 2018-08-14 10:22:34 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.
Comment 8 Ben Cotton 2019-10-31 20:51:39 UTC 
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 9 Vít Ondruch 2019-11-01 12:55:54 UTC 
rubygem-closure-compiler was retired from Fedora, therefore this can be closed:

https://src.fedoraproject.org/rpms/rubygem-closure-compiler/c/c0d447db3557cba0d0134e9ab21b9e222066df41?branch=master