Bug 1353518
| Summary: | packaging: rpmlint warning and errors | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Nigel Babu <nigelb> |
| Component: | packaging | Assignee: | Sheetal Pamecha <spamecha> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | mainline | CC: | bugs, kkeithle, moagrawa, ndevos, ravishankar |
| Target Milestone: | --- | Keywords: | StudentProject, Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1303668 | Environment: | |
| Last Closed: | 2020-03-12 12:49:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1303668 | ||
| Bug Blocks: | |||
|
Description
Nigel Babu
2016-07-07 11:31:27 UTC
We are in a slightly better state now (6.1):
{
"module" : "ManPages",
"order" : 45,
"results" : [
{
"arch" : "armv7hl,x86_64",
"code" : "ManPageMissing",
"diag" : "No man page for <tt>/usr/sbin/conf.py</tt>",
"subpackage" : "glusterfs-server"
},
{
"arch" : "armv7hl,x86_64",
"code" : "ManPageMissing",
"diag" : "No man page for <tt>/usr/sbin/gcron.py</tt>",
"subpackage" : "glusterfs-server"
},
{
"arch" : "armv7hl,x86_64",
"code" : "ManPageMissing",
"diag" : "No man page for <tt>/usr/sbin/gf_attach</tt>",
"subpackage" : "glusterfs-server"
},
{
"arch" : "armv7hl,x86_64",
"code" : "ManPageMissing",
"diag" : "No man page for <tt>/usr/sbin/glfsheal</tt>",
"subpackage" : "glusterfs-server"
},
{
"arch" : "armv7hl,x86_64",
"code" : "ManPageMissing",
"diag" : "No man page for <tt>/usr/sbin/snap_scheduler.py</tt>",
"subpackage" : "glusterfs-server"
}
],
"run_time" : 0,
"status" : "completed"
},
{
"module" : "RpmScripts",
"order" : 90,
"results" : [
{
"arch" : "src",
"code" : "UseraddNoUid",
"context" : {
"excerpt" : [
"useradd -r -g gluster -d %{_rundir}/gluster -s /sbin/nologin -c "GlusterFS daemons" gluster"
],
"lineno" : 948,
"path" : "glusterfs.spec",
"sub" : "%pre"
},
"diag" : "Invocation of <tt>useradd</tt> without specifying a UID; this may be OK, because /usr/share/doc/setup/uidgid defines no UID for <var>gluster</var>"
}
],
"run_time" : 0,
"status" : "completed"
},
{
"module" : "Setxid",
"order" : 91,
"results" : [
{
"arch" : "armv7hl,x86_64",
"code" : "UnauthorizedSetxid",
"context" : {
"path" : "/usr/bin/fusermount-glusterfs"
},
"diag" : "File <var>/usr/bin/fusermount-glusterfs</var> is setuid root but is not on the setxid whitelist.",
"subpackage" : "glusterfs-fuse"
}
],
"run_time" : 0,
Mohit, is there any reason for an administrator to execute /usr/sbin/gf_attach ? In case this is not a common, we do not need to add a man-page, but we can move the executable to /usr/libexec/ instead. Ravi, is there any reason for an administrator to execute /usr/sbin/glfsheal ? In case this is not common, we do not need to add a man-page, but we can move the executable to /usr/libexec/ instead. Aravinda, which of the python scripts does an administrator need to execute for the snapshot-scheduler? Can they be installed under the Python package directory (or maybe /usr/libexec/) instead? It is also not very common to have executables in the path with a .py extension, it would be nice to address that too. (In reply to Niels de Vos from comment #3) > Ravi, is there any reason for an administrator to execute /usr/sbin/glfsheal > ? In case this is not common, we do not need to add a man-page, but we can > move the executable to /usr/libexec/ instead. glfsheal is invoked internally by the gluster CLI code with the appropriate arguments when the relevant heal info/ split-brain resolution gluster CLI commands are run. There is no need to expose glfsheal directly to the admins. Not sure if we need to make changes to the all invocations in gluster if we move the program to libexec: cli/src/cli-cmd-volume.c: runner_add_args(&runner, SBIN_DIR "/glfsheal", volname, NULL); (In reply to Niels de Vos from comment #4) > Aravinda, which of the python scripts does an administrator need to execute > for the snapshot-scheduler? Can they be installed under the Python package > directory (or maybe /usr/libexec/) instead? It is also not very common to > have executables in the path with a .py extension, it would be nice to > address that too. I don't have much context on this component at the moment, I will look into the code and move to libexec. `conf.py` and `gcron.py` can be moved to other location but at least one binary(currently it is python file, but we can have symlink) is required in sbin because it is used by the end users.(I think libexec is only used for programs executed by non-users internally by applications) This bug is moved to https://github.com/gluster/glusterfs/issues/958, and will be tracked there from now on. Visit GitHub issues URL for further details |