Bug 1353685

Summary: Windows productID value in provisioning dialogs should never be required by default
Product: Red Hat CloudForms Management Engine Reporter: James Rankin <jrankin>
Component: AutomateAssignee: Drew Bomhof <dbomhof>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: greartes, jhardy, jteehan, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone: GA   
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: automate:provisioning:windows
Fixed In Version: 5.7.0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-04 12:56:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:

Description James Rankin 2016-07-07 17:24:44 UTC
In the out of the box VM Provisioning Dialogs, such as miq_provision_vmware_dialogs_template, productIDs are required for windows. For instance:

    :sysprep_product_id:
        :description: ProductID
        :required_method: :validate_sysprep_field
        :required: true
        :display: :edit
        :data_type: :string


Most customers use key servers now, so there is no correct value that can be entered here. Also, the newer versions of VMware do NOT require this field in a guest customization spec (for the same reason - key servers), so there's no need for CFME to require it.

All "out of the box" provisioning dialogs should be modified to default to "required: false" on this field.

Comment 5 CFME Bot 2016-09-13 22:21:19 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1b78124d0afafde9d8d7a59111da7d220e4b310d

commit 1b78124d0afafde9d8d7a59111da7d220e4b310d
Author:     Drew Bomhof <dbomhof>
AuthorDate: Tue Sep 13 14:30:51 2016 -0400
Commit:     Drew Bomhof <dbomhof>
CommitDate: Tue Sep 13 14:30:51 2016 -0400

    sysprep_product_id set to required false
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1353685

 product/dialogs/miq_dialogs/miq_provision_dialogs.yaml                  | 2 +-
 .../miq_dialogs/miq_provision_vmware_dialogs_clone_to_template.yaml     | 2 +-
 .../dialogs/miq_dialogs/miq_provision_vmware_dialogs_clone_to_vm.yaml   | 2 +-
 product/dialogs/miq_dialogs/miq_provision_vmware_dialogs_template.yaml  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Comment 6 Jeff Teehan 2016-10-12 16:43:45 UTC
This has been changed.  Tested in 5704 on 10.16.7.123

      :sysprep_product_id:
        :description: ProductID
        :required_method: :validate_sysprep_field
        :required: false
        :display: :edit
        :data_type: :string

Comment 8 errata-xmlrpc 2017-01-04 12:56:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html