Bug 1353934

Summary:	NT escaping in shebang in easy_install
Product:	Red Hat Enterprise Linux 7	Reporter:	Jan Pokorný [poki] <jpokorny>
Component:	python-setuptools	Assignee:	Python Maintainers <python-maint>
Status:	CLOSED WONTFIX	QA Contact:	BaseOS QE - Apps <qe-baseos-apps>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.1	CC:	cstratak, hhorak, isenfeld, mcyprian
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1387561 (view as bug list)		Environment:
Last Closed:	2017-02-15 18:42:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1343661, 1380359, 1387561, 1393868

Description Jan Pokorný [poki] 2016-07-08 12:46:34 UTC

See
https://github.com/pypa/setuptools/issues/188

This prevents equivalent of
https://pkgs.fedoraproject.org/cgit/rpms/clufter.git/tree/clufter.spec?id=8c9ee7115ce2b5f25eeefc7e0247a1f3128e9662#n127
i.e.,
> # make Python interpreter executation sane (via -Es flags)
> %{__python2} setup.py saveopts -f setup.cfg build_scripts \
>                       "--executable=%{__python2} -Es"

from working properly in RHEL 7, simply because the generated shebang
reads:
> #!"/usr/bin/python2 -Es"
which is indeed invalid.


As an aside, I think it would be reasonable to have setuptools
(and friends) patched to the same effect (as opposed to patching
every and each package defining console_scripts in setup.py)
as a sane (and supportable!) default.

Comment 3 Michal Cyprian 2017-02-07 15:51:26 UTC

Upstream issue https://github.com/pypa/setuptools/issues/188 was finally fixed in version 20.6. There is setuptools 0.9.8 in RHEL 7. easy_install command, specially the part that handles scripts was changed completely since version 0.9.8 (class ScriptWriter). There is not any simple upstream patch, which could be backported.

Comment 4 Charalampos Stratakis 2017-02-15 18:42:39 UTC

Unfortunately as Michal already pointed out there have way too many changes upstream when the fix was implemented, so currently a backport of the fix is impossible without refactoring a lot of the relevant setuptools code.

This would be a very invasive change on the way that shebangs are being generated currently, so in this case there is an elevated risk that the current working shebang generation will break (or break other working corner cases), just to fix this specific corner case.

In this particular situation that you reported it would be preferable that the workaround is being used at the individual components, rather than fixing setuptools itself.

Closing it as WONTFIX.