Bug 1354180

Summary:	[RFE] remove 'FIX_RELEASE=' from version.mak file
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Edri <eedri>
Component:	Packaging.rpm	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Eyal Edri <eedri>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	4.1.0	CC:	bugs, eedri, sbonazzo, ylavi
Target Milestone:	ovirt-4.1.0-alpha	Keywords:	CodeChange, FutureFeature
Target Release:	4.1.0.2	Flags:	rule-engine: ovirt-4.1+ ylavi: planning_ack+ sbonazzo: devel_ack+ pstehlik: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-04 15:34:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Edri 2016-07-10 11:53:29 UTC

Description of problem:
Today we have duplicate update of files each time we release a new build of ovirt-engine.

First we update all pom.xml files to latest version that matches the new official tag, but we also update the 'version.mak' file with

FIX_RELEASE=X, where X is usually the minor version which correlates to the version we used in pom.xml.

For e.g, if ovirt-engine version on pom.xml is 3.6.8 then FIX_RELEASE=8.
If version is 4.0.1.1 then FIX_RELEASE=1.1 

So instead of updating version.mak manually each time and exposing it to human errors and rebase conflicts with downstream branches, we can easily get the value it needs from the pom.xml file

If its possible to do inside the spec file or another place, I think it will simplify the build process and take us one step forward towards automation of the official builds.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Sandro Bonazzola 2016-12-12 14:02:17 UTC

The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 2 Gil Klein 2017-04-04 13:01:41 UTC

Eyal, Based on comment #1 , can this RFE move to verified?