Bug 1354202
| Summary: | Review Request: purple-hangouts - Adds support for Hangouts to libpurple-based clients | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vitaly <vitaly> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ignatenko, package-review |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-28 23:54:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vitaly
2016-07-10 17:27:03 UTC
Will make review in few hours. > Version: 1.0 actually it was never released, so version is: 0 > BuildRequires: pkgconfig(nss) not used > %post -p /sbin/ldconfig not needed, as library installs into private directory spec and SRPM's spec are different: Diff spec file in url and in SRPM --------------------------------- --- /home/brain/1354202-purple-hangouts/srpm/purple-hangouts.spec 2016-07-10 20:34:47.236258515 +0200 +++ /home/brain/1354202-purple-hangouts/srpm-unpacked/purple-hangouts.spec 2016-07-10 19:24:36.000000000 +0200 @@ -55,4 +55,9 @@ chmod 755 %{buildroot}%{_libdir}/purple-2/lib%{plugin_name}.so +# Installing icons... +install -p hangouts16.png %{buildroot}%{_datadir}/pixmaps/pidgin/protocols/16/%{plugin_name}.png +install -p hangouts22.png %{buildroot}%{_datadir}/pixmaps/pidgin/protocols/22/%{plugin_name}.png +install -p hangouts48.png %{buildroot}%{_datadir}/pixmaps/pidgin/protocols/48/%{plugin_name}.png + %files %{_libdir}/purple-2/lib%{plugin_name}.so > actually it was never released, so version is: 0 Fixed. > not needed, as library installs into private directory Already removed in new SPEC. > spec and SRPM's spec are different: Resolved. New SRPM: https://copr-be.cloud.fedoraproject.org/results/xvitaly/purple-hangouts/fedora-24-x86_64/00376098-purple-hangouts/purple-hangouts-0-31.20160710hg5378549.fc24.src.rpm everything looks good except CFLAGS/LDFLAGS are not used. > everything looks good except CFLAGS/LDFLAGS are not used. Fixed in upstream. New SRPM: https://copr-be.cloud.fedoraproject.org/results/xvitaly/purple-hangouts/fedora-24-x86_64/00381440-purple-hangouts/purple-hangouts-0-33.20160712hg2c60a5e.fc24.src.rpm Nothing I can complain about according to guidelines, only note: > Source0: https://bitbucket.org/EionRobb/purple-hangouts/get/%{commit0}.tar.gz#/purple-hangouts-%{shortcommit0}.tar.gz Source0: https://bitbucket.org/EionRobb/purple-hangouts/get/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/purple-hangouts purple-hangouts-0-34.20160714hgd6eb7fe.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-084d75739e purple-hangouts-0-34.20160714hgd6eb7fe.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8a7b33ec2 purple-hangouts-0-34.20160714hgd6eb7fe.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d79e976dda purple-hangouts-0-34.20160714hgd6eb7fe.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d79e976dda purple-hangouts-0-34.20160714hgd6eb7fe.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-084d75739e purple-hangouts-0-34.20160714hgd6eb7fe.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8a7b33ec2 purple-hangouts-0-34.20160714hgd6eb7fe.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. purple-hangouts-0-34.20160714hgd6eb7fe.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. purple-hangouts-0-34.20160714hgd6eb7fe.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |