Bug 1355782

Summary: Advanced Setting screen only shows the first 24 lines until browser resize
Product: Red Hat CloudForms Management Engine Reporter: Dan Clarizio <dclarizi>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Ramesh A <rananda>
Severity: medium Docs Contact:
Priority: high    
Version: 5.7.0CC: cpelland, hkataria, jhardy, mhradil, mpovolny, obarenbo, rananda, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:configuration:browser
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1356133 (view as bug list) Environment:
Last Closed: 2017-01-11 19:56:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1356133    
Attachments:
Description Flags
Advanced Settings limited lines showing none

Description Dan Clarizio 2016-07-12 14:14:59 UTC
Created attachment 1178914 [details]
Advanced Settings limited lines showing

Description of problem:
The first 24 lines of settings are only shown along with double scroll bars (see attachement)

Version-Release number of selected component (if applicable):
5.7.0

How reproducible:
Go to advanced settings

Actual results:
Only see first 24 settings lines

Expected results:
Fully scrollable list of settings in CodeMirror

Additional info:
This was introduced with CodeMirror gem changes

Comment 5 CFME Bot 2016-07-20 16:05:45 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/97727d05b47be47f40b3a1fd5b0138daefb81e43

commit 97727d05b47be47f40b3a1fd5b0138daefb81e43
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Jul 14 12:07:06 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Jul 18 12:21:16 2016 +0000

    Ops settings advanced - codemirror should show more than 24 lines
    
    codemirror with height:auto still renders only few lines - forcing viewportMargin to Infinity fixes that
    
    ..and adding a missing refresh call
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1355782

 app/assets/javascripts/miq_application.js      | 1 +
 app/views/ops/_settings_advanced_tab.html.haml | 2 ++
 2 files changed, 3 insertions(+)

Comment 6 CFME Bot 2016-07-22 02:05:42 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/eced80afdab4f879c29b43bcd9c94633e328b198

commit eced80afdab4f879c29b43bcd9c94633e328b198
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Jul 14 12:07:06 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Jul 21 09:56:26 2016 +0000

    Ops settings advanced - codemirror should show more than 24 lines
    
    codemirror with height:auto still renders only few lines - forcing viewportMargin to Infinity fixes that
    
    ..and adding a missing refresh call
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1355782

 app/assets/javascripts/miq_application.js      | 1 +
 app/views/ops/_settings_advanced_tab.html.haml | 2 ++
 2 files changed, 3 insertions(+)

Comment 7 Ramesh A 2016-10-05 07:59:23 UTC
Good to go.  Verified and working fine in 5.7.0.3.20160927165516_075d0f3