Bug 1355895
| Summary: | User_data is being base64 encoded twice causing init script to fail for Openstack provisioning | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Jared Deubel <jdeubel> | |
| Component: | Provisioning | Assignee: | Brandon Dunne <bdunne> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Leo Khomenko <lkhomenk> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.6.0 | CC: | bdunne, cpelland, dajohnso, jdeubel, jhardy, lcouzens, lkhomenk, obarenbo, rrasouli, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.7.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.7.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1356251 1356706 (view as bug list) | Environment: | ||
| Last Closed: | 2017-01-11 20:04:35 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1384506 | |||
| Bug Blocks: | 1356251, 1356706 | |||
|
Comment 2
Greg McCullough
2016-07-12 21:23:05 UTC
Based on the logging, this isn't AWS, it's openstack. Jared, can you confirm that the users problem is with openstack as the logging indicates? New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/42582320062c6330c92a97931d8d624b24e4edda commit 42582320062c6330c92a97931d8d624b24e4edda Author: Brandon Dunne <bdunne> AuthorDate: Wed Jul 13 17:38:45 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Wed Jul 13 18:11:21 2016 -0400 Don't Base64.encode64 by default, it doesn't apply to every provider https://bugzilla.redhat.com/show_bug.cgi?id=1355895 .../manageiq/providers/azure/cloud_manager/provision.rb | 1 + .../providers/azure/cloud_manager/provision/configuration.rb | 6 ++++++ .../providers/cloud_manager/provision/configuration.rb | 4 ++-- .../azure/cloud_manager/provision/configuration_spec.rb | 11 +++++++++++ .../manageiq/providers/cloud_manager/configuration_spec.rb | 6 +++--- 5 files changed, 23 insertions(+), 5 deletions(-) create mode 100644 app/models/manageiq/providers/azure/cloud_manager/provision/configuration.rb create mode 100644 spec/models/manageiq/providers/azure/cloud_manager/provision/configuration_spec.rb New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/d5c18983e85f7b522d93a8bf25c88ab3487f0d12 commit d5c18983e85f7b522d93a8bf25c88ab3487f0d12 Author: Brandon Dunne <bdunne> AuthorDate: Wed Jul 13 18:04:18 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Wed Jul 13 18:11:25 2016 -0400 Remove extra contexts https://bugzilla.redhat.com/show_bug.cgi?id=1355895 .../azure/cloud_manager/provision/configuration_spec.rb | 14 ++++++-------- .../manageiq/providers/cloud_manager/configuration_spec.rb | 14 ++++++-------- 2 files changed, 12 insertions(+), 16 deletions(-) New commit detected on manageiq-providers-amazon/master: https://github.com/ManageIQ/manageiq-providers-amazon/commit/f4dae45b7841899def478834cc05dc565842614c commit f4dae45b7841899def478834cc05dc565842614c Author: Brandon Dunne <bdunne> AuthorDate: Wed Jul 13 18:10:30 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Fri Jul 15 12:32:12 2016 -0400 Ensure user_data is Base64 encoded https://bugzilla.redhat.com/show_bug.cgi?id=1355895 .../providers/amazon/cloud_manager/provision/configuration.rb | 5 +++++ .../amazon/cloud_manager/provision/configuration_spec.rb | 11 +++++++++++ 2 files changed, 16 insertions(+) create mode 100644 spec/models/manageiq/providers/amazon/cloud_manager/provision/configuration_spec.rb New commit detected on ManageIQ/manageiq/darga: https://github.com/ManageIQ/manageiq/commit/bb54d03b333e93ca13dbdcf0afed1cabf4bce283 commit bb54d03b333e93ca13dbdcf0afed1cabf4bce283 Author: Brandon Dunne <bdunne> AuthorDate: Wed Jul 13 17:38:45 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon Jul 18 12:01:11 2016 -0400 Don't Base64.encode64 by default, it doesn't apply to every provider https://bugzilla.redhat.com/show_bug.cgi?id=1355895 .../manageiq/providers/azure/cloud_manager/provision.rb | 1 + .../providers/azure/cloud_manager/provision/configuration.rb | 6 ++++++ .../providers/cloud_manager/provision/configuration.rb | 4 ++-- .../providers/amazon/cloud_manager/provision/configuration.rb | 5 +++++ .../amazon/cloud_manager/provision/configuration_spec.rb | 11 +++++++++++ .../azure/cloud_manager/provision/configuration_spec.rb | 11 +++++++++++ .../manageiq/providers/cloud_manager/configuration_spec.rb | 6 +++--- 7 files changed, 39 insertions(+), 5 deletions(-) create mode 100644 app/models/manageiq/providers/azure/cloud_manager/provision/configuration.rb create mode 100644 gems/manageiq-providers-amazon/spec/models/manageiq/providers/amazon/cloud_manager/provision/configuration_spec.rb create mode 100644 spec/models/manageiq/providers/azure/cloud_manager/provision/configuration_spec.rb New commit detected on ManageIQ/manageiq/darga: https://github.com/ManageIQ/manageiq/commit/321791147d12ba1bd361090adb9f5f490826c34a commit 321791147d12ba1bd361090adb9f5f490826c34a Author: Brandon Dunne <bdunne> AuthorDate: Wed Jul 13 18:04:18 2016 -0400 Commit: Brandon Dunne <bdunne> CommitDate: Mon Jul 18 12:01:18 2016 -0400 Remove extra contexts https://bugzilla.redhat.com/show_bug.cgi?id=1355895 .../azure/cloud_manager/provision/configuration_spec.rb | 14 ++++++-------- .../manageiq/providers/cloud_manager/configuration_spec.rb | 14 ++++++-------- 2 files changed, 12 insertions(+), 16 deletions(-) This fix is merged to master and should be in "POST" *** Bug 1331806 has been marked as a duplicate of this bug. *** Leo, I'm not sure I understand your concern. Are you testing against a provider and seeing an error? I'm just asking - why do we have "\n" in user-data in fog.log? Such string is not a base64 and if one needs it he'll have remove them manually. provisioning with cloud_init now works and user-data is encoded only once "\n" in user-data is an item for RFE. in general - user-data is encoded only once, as it should be |