Bug 1356290

Summary: Subscriptions validation will always report insufficient entitlements when using an SMA with zero subs.
Product: Red Hat Quickstart Cloud Installer Reporter: Erik Nelson <ernelson>
Component: fusor-serverAssignee: Jesus M. Rodriguez <jesusr>
Status: CLOSED CURRENTRELEASE QA Contact: Dave Johnson <dajohnso>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.0CC: jesusr
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-06 15:50:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Arguments submitted to compare none

Description Erik Nelson 2016-07-13 21:47:10 UTC 
Created attachment 1179464 [details]
Arguments submitted to compare

Description of problem:
Subscription validation logic will always report a warning when using an SMA that starts with 0 subscriptions, even if you add enough to cover the deployment. Issue is related to https://github.com/fusor/fusor/blob/master/server/app/lib/fusor/subscriptions/subscription_validator.rb#L121, we do not get any entitlements back from the customer portal, so the product_ids end up incorrect.

See attachment for log of rails console session, should arguments passed to compare method.

How reproducible:
Every time.

Steps to Reproduce:
1. Do a connected deployment (must not have a previously uploaded manifest).
2. Choose SMA with 0 subscriptions.
3. Add sufficient subscriptions to cover the deployment (ex: 2RHCI to cover just RHEV)
4. Progress to subscriptions review

Actual results:
Warning appears complaining about insufficient entitlements.

Expected results:
No warning should appear.

Additional info:
Comment 1 Jesus M. Rodriguez 2016-07-15 17:25:42 UTC 
https://github.com/fusor/fusor/pull/1050