Bug 1356508

Summary: [RFE] Handle errors during SSH key generation(gsec_create)
Product: [Community] GlusterFS Reporter: Aravinda VK <avishwan>
Component: geo-replicationAssignee: Aravinda VK <avishwan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-27 18:20:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Aravinda VK 2016-07-14 09:50:35 UTC
Description of problem:
Existing command will not how SSH keygen error messages when a peer node is down. gsec_create should show the summary of keygen status.

Comment 1 Vijay Bellur 2016-07-14 09:52:51 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#2) for review on master by Aravinda VK (avishwan)

Comment 2 Aravinda VK 2016-07-14 10:02:12 UTC
Introduced new alternate command instead of changing already existing command.

Usage: 

    gluster-georep-sshkey generate
    or
    gluster-georep-sshkey generate --no-prefix

Above commands are equivalents of `gluster system:: execute gsec_create` and `gluster system:: execute gsec_create container` respectively.

After one release we can deprecate and remove the old command.

Comment 3 Vijay Bellur 2016-08-04 09:24:21 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#3) for review on master by Aravinda VK (avishwan)

Comment 4 Vijay Bellur 2016-08-09 07:34:16 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#4) for review on master by Aravinda VK (avishwan)

Comment 5 Worker Ant 2016-08-25 08:16:38 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#5) for review on master by Aravinda VK (avishwan)

Comment 6 Worker Ant 2016-08-30 14:07:19 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#6) for review on master by Aravinda VK (avishwan)

Comment 7 Worker Ant 2016-08-31 05:36:28 UTC
REVIEW: http://review.gluster.org/14732 (geo-rep: Alternate command to generate SSH Keys) posted (#7) for review on master by Aravinda VK (avishwan)

Comment 8 Worker Ant 2016-08-31 10:09:16 UTC
COMMIT: http://review.gluster.org/14732 committed in master by Aravinda VK (avishwan) 
------
commit 29a57765d524af8ec0e5bab17e5ff7f47b968342
Author: Aravinda VK <avishwan>
Date:   Wed Jun 15 13:54:37 2016 +0530

    geo-rep: Alternate command to generate SSH Keys
    
    `gluster system:: execute gsec_create` is used to generate SSH
    Keys in all Master nodes and collect public keys in command initiated
    node. But this tool will not provide details if a peer node is down and
    unable to generate keys.
    
    New command will be introduced to create SSH Keys in all peer nodes.
    
    Usage:
    
        gluster-georep-sshkey generate
        or
        gluster-georep-sshkey generate --no-prefix
    
    Generates two SSH keys(one for gsyncd access and other for tar) in all
    peer nodes and collects the public keys to the local node where it is
    initiated. Adds `command=` prefix to common_secret.pem.pub if `--no-prefix`
    argument is not set.
    
    Shows status as below,
    
    +-----------+-------------+---------------+
    |    NODE   | NODE STATUS | KEYGEN STATUS |
    +-----------+-------------+---------------+
    |    fvm2   |          UP |            OK |
    | localhost |          UP |            OK |
    +-----------+-------------+---------------+
    
    BUG: 1356508
    Change-Id: Ib202811f41f9986694f07d9eedba31db6ed4d18f
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/14732
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>

Comment 9 Shyamsundar 2017-03-27 18:20:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/