Bug 1356650

Summary: vagrant: Want to use rest-client 2.0
Product: [Fedora] Fedora Reporter: Jun Aruga <jaruga>
Component: vagrantAssignee: Vít Ondruch <vondruch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: lmohanty, madam, strzibny, thrcka, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vagrant-1.8.1-3.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-25 14:45:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1356673    
Attachments:
Description Flags
Support rest-client 2.x none

Description Jun Aruga 2016-07-14 15:04:26 UTC 
Description of problem:

I want to update rubygem-rest-client from 1.8 to 2.0.
However vagrant RPM spec file depends on rubygem(rest-client) < 2.0 .

Could you change from "rubygem(rest-client) < 2.0" to "rubygem(rest-client)" in the spec file?

Thanks.


Additional info:
The reason why I want to update rubygem-rest-client to 2.0 is

rest-client-1.8 depends on mime-types < 3.
rest-client-2.0 supports latest version: mime-types 3.1.
Finally I want to use mime-types 3.1.
Comment 1 Vít Ondruch 2016-07-15 07:35:43 UTC 
(In reply to Jun Aruga from comment #0)
> Could you change from "rubygem(rest-client) < 2.0" to "rubygem(rest-client)"
> in the spec file?

This dependency is autogenerated and comes from upstream:

https://github.com/mitchellh/vagrant/blob/master/vagrant.gemspec#L34

You probably want to investigate why the dependency is restricted to "< 2.0" and discuss with upstream first.
Comment 2 Jun Aruga 2016-07-15 08:29:36 UTC 
(In reply to Vít Ondruch from comment #1)
> (In reply to Jun Aruga from comment #0)
> > Could you change from "rubygem(rest-client) < 2.0" to "rubygem(rest-client)"
> > in the spec file?
> 
> This dependency is autogenerated and comes from upstream:
> 
> https://github.com/mitchellh/vagrant/blob/master/vagrant.gemspec#L34
> 
> You probably want to investigate why the dependency is restricted to "< 2.0"
> and discuss with upstream first.

okay, thanks for your information!
Comment 3 Jun Aruga 2016-07-15 11:19:20 UTC 
(In reply to Jun Aruga from comment #2)
> (In reply to Vít Ondruch from comment #1)
> > (In reply to Jun Aruga from comment #0)
> > > Could you change from "rubygem(rest-client) < 2.0" to "rubygem(rest-client)"
> > > in the spec file?
> > 
> > This dependency is autogenerated and comes from upstream:
> > 
> > https://github.com/mitchellh/vagrant/blob/master/vagrant.gemspec#L34
> > 
> > You probably want to investigate why the dependency is restricted to "< 2.0"
> > and discuss with upstream first.
> 
> okay, thanks for your information!

Asking here, I could passed upstream's unit test with Ruby 2.2.5 and 2.2.3 after I updated the dependency.
https://github.com/mitchellh/vagrant/pull/7589
Comment 4 Jun Aruga 2016-07-18 09:51:56 UTC 
(In reply to Jun Aruga from comment #3)
> Asking here, I could passed upstream's unit test with Ruby 2.2.5 and 2.2.3
> after I updated the dependency.
> https://github.com/mitchellh/vagrant/pull/7589

Vit,
My patch to use rest-client 2.0 was accepted to the upstream.
I am going to prepare the patch to use rest-client 2.0 for this vagrant package, and upload it here.
Comment 5 Jun Aruga 2016-07-18 11:31:27 UTC 
Created attachment 1181023 [details]
Support rest-client 2.x

Hi,
I created the patch to support rest-client 2.x.
Could you check my patch?
Thanks.
Comment 6 Vít Ondruch 2016-07-25 14:45:58 UTC 
Thx for the patch. I applied it in Rawhide.