Bug 135669 (IT_71111)

Summary: tcsendbreak fails in compat mode
Product: Red Hat Enterprise Linux 4 Reporter: Gordon Jin <gordon.jin>
Component: kernelAssignee: Jason Baron <jbaron>
Status: CLOSED ERRATA QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: jparadis, knoel, riel, tao
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: RHSA-2005-514 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-10-05 12:30:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 154907, 156322    
Attachments:
Description Flags
compat_ioctl_tcsbrkp.patch none

Description Gordon Jin 2004-10-14 09:36:10 UTC 
Description of problem:
ioctl TCSBRKP is needed for POSIX tcsendbreak().  
But arch/x86_64/ia32 doesn't support TCSBRKP.
So x86 application calling tcsendbreak() will fail on x86_64 with 
compat mode.

How reproducible:
Always

Steps to Reproduce:
Run an x86 program calling tcsendbreak() in compat mode.
E.g. LTP case ptem01 uses tcsendbreak(), which calls ioctl(3, 
TCSBRKP, 0x1). 
  
Actual results:
The call failed.

Expected results:
The call should succeed.
Comment 1 Gordon Jin 2004-10-14 09:41:24 UTC 
I'll post the patch later.
The solution to add TCSBRKP in arch/x86_64/ia32/ia32_ioctl.c is 
simple. 
But better we need discuss with other compat archs to see if it's OK 
to moving it to compat_ioctl.c.
Comment 2 Gordon Jin 2004-11-11 01:31:45 UTC 
Created attachment 106465 [details]
compat_ioctl_tcsbrkp.patch

This patch fixes.
It's already sent to community, and will probably go into mainstream soon.
Comment 3 Gordon Jin 2004-12-02 17:36:22 UTC 
How about including this patch in RHEL4?
Comment 4 Keve Gabbert 2005-01-31 09:22:53 UTC 
Gordon, has this patch been accepted upstream?
Comment 5 Gordon Jin 2005-02-01 03:20:01 UTC 
I just checked and found the answer is no. It looks like it is 
dropped somehow. I'm pushing again.
Comment 6 Gordon Jin 2005-03-09 08:05:03 UTC 
This patch has been in mainline tree:
http://linux.bkbits.net:8080/linux-2.5/cset@1.2020.4.114

Please apply.
Comment 18 Red Hat Bugzilla 2005-10-05 12:30:48 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-514.html