Bug 1356973

Summary: Dialogue Input are truncated when submitted
Product: Red Hat CloudForms Management Engine Reporter: John Prause <jprause>
Component: AutomateAssignee: eclarizi
Status: CLOSED ERRATA QA Contact: Milan Falešník <mfalesni>
Severity: medium Docs Contact:
Priority: high    
Version: 5.6.0CC: cpelland, dajohnso, eclarizi, gmccullo, hkataria, jhardy, jistefan, mfalesni, mkanoor, mmojzis, mpovolny, obarenbo, tfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.6.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: automate:dialog:ui
Fixed In Version: 5.6.1.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1355841 Environment:
Last Closed: 2016-08-18 17:59:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1355841    
Bug Blocks:    

Comment 3 CFME Bot 2016-07-19 16:41:05 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/d2095d15de05fef022a8d6551fd058854442105a

commit d2095d15de05fef022a8d6551fd058854442105a
Author:     Erik Clarizio <eclarizi>
AuthorDate: Mon Jul 18 09:08:27 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Tue Jul 19 08:06:36 2016 -0700

    Remove interval from data-miq_observe on textbox and textarea boxes
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1356973

 app/helpers/application_helper/dialogs.rb       | 2 --
 spec/helpers/application_helper/dialogs_spec.rb | 6 ++----
 2 files changed, 2 insertions(+), 6 deletions(-)

Comment 4 CFME Bot 2016-07-19 16:41:10 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/cc4accacdd0869287fdfa48d06ace382ce9539b9

commit cc4accacdd0869287fdfa48d06ace382ce9539b9
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 15 00:38:42 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Tue Jul 19 08:06:31 2016 -0700

    Ensure dialog field refreshes wait for requests in the MiqObserve queue
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1356973

 app/assets/javascripts/dialog_field_refresh.js | 157 ++++++++-------
 app/assets/javascripts/miq_application.js      |   1 +
 spec/javascripts/dialog_field_refresh_spec.js  | 252 +++++++++++++++++++++++--
 3 files changed, 320 insertions(+), 90 deletions(-)

Comment 5 CFME Bot 2016-07-19 16:41:15 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/cefb7383c5ccd57376b7305d3ee9a591744258b1

commit cefb7383c5ccd57376b7305d3ee9a591744258b1
Author:     Erik Clarizio <eclarizi>
AuthorDate: Mon Jul 18 09:09:07 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Tue Jul 19 08:06:41 2016 -0700

    Use leading: true for observe and miqSelectPickerEvent debounces
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1356973

 app/assets/javascripts/miq_application.js  | 2 +-
 app/assets/javascripts/miq_ujs_bindings.js | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comment 7 Milan Falešník 2016-08-03 09:06:37 UTC
So, if I understand it correctly:

1) the method that is hooked to the dropdown prints the value of the textbox
2) I click in the textbox, put my mouse over the refresh button
3) randomly smash keyboard and immediately click the refresh button
4) watch the log and whatever was in the text box when refresh was clicked, must be displayed?

I did these and it seems working, but if there is another catch, I am happy to check that too.

Comment 8 eclarizi 2016-08-03 14:23:28 UTC
Yup, especially the first part of step 3 :).

It's not required that the drop-down method prints the value of the textbox, but that does make it easier to test since you'll be able to tell if the whole value from the textbox made it to the server or not. In the original customer issue, they had a text box and a drop-down, and they didn't discover the truncation until submitting.

Comment 9 Milan Falešník 2016-08-04 13:15:37 UTC
So I tried to reproduce this error with dynamic dropdowns and refresh in 5.6.1.0 but I could not get the text to be truncated, so I believe this bug is no longer present in 5.6.1.0.

Comment 11 errata-xmlrpc 2016-08-18 17:59:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-1634.html