Bug 1357046
| Summary: | Updating a repo without specifying checksum_type causes key_error in Pulp | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Roman Plevka <rplevka> |
| Component: | Pulp | Assignee: | satellite6-bugs <satellite6-bugs> |
| Status: | CLOSED ERRATA | QA Contact: | Roman Plevka <rplevka> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.2.0 | CC: | bbuckingham, bkearney, bmbouter, daviddavis, dkliban, ehelms, fdobrovo, ggainey, ipanova, mhrivnak, pcreech, rchan, ttereshc |
| Target Milestone: | Unspecified | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-21 16:51:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Roman Plevka
2016-07-15 14:55:38 UTC
The error observed in the log file is not fatal and does not appear to affect the creation or updating of a repository. That said, we should look to address this error to minimize confusion. Note: Although it is a difference scenario, the behavior here is very similar to the issue raised in bug 1356111. I suspect that this is more fatal than it may initially appear. The operation is likely updating the importer first, and then any distributors. If you only were trying to change an importer setting, that would work, and the error would appear to not cause any problems. But if you tried to update a distributor setting in that operation, I bet this error would prevent it from working. I was unable to reproduce this with pulp-admin on pulp-2.8.4-1. Can someone please provide either more specific reproducer steps with pulp, or a machine that exhibits the problem? The Pulp upstream bug status is at ASSIGNED. Updating the external tracker on this bug. The Pulp upstream bug priority is at High. Updating the external tracker on this bug. The Pulp upstream bug status is at POST. Updating the external tracker on this bug. The Pulp upstream bug status is at MODIFIED. Updating the external tracker on this bug. The Pulp upstream bug status is at ON_QA. Updating the external tracker on this bug. Moving to POST since this is fixed in Pulp. The Pulp upstream bug status is at VERIFIED. Updating the external tracker on this bug. The Pulp upstream bug status is at CLOSED - CURRENTRELEASE. Updating the external tracker on this bug. VERIFIED
on sat6.2.7 snap 1
the error seems to be gone:
2017-01-09 10:13:46 [app] [I] Started GET "/katello/api/products/1/repositories?name=foo_repo_cli_1&organization_id=1" for ::1 at 2017-01-09 10:13:46 -0500
2017-01-09 10:13:46 [app] [I] Processing by Katello::Api::V2::RepositoriesController#index as JSON
2017-01-09 10:13:46 [app] [I] Parameters: {"name"=>"foo_repo_cli_1", "organization_id"=>"1", "api_version"=>"v2", "product_id"=>"1", "repository"=>{}}
2017-01-09 10:13:46 [app] [I] Authorized user admin(Admin User)
2017-01-09 10:13:46 [app] [I] Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.92/app/views/katello/api/v2/repositories/index.json.rabl within katello/api/v2/layouts/collection (22.1ms)
2017-01-09 10:13:46 [app] [I] Completed 200 OK in 58ms (Views: 19.7ms | ActiveRecord: 11.0ms)
2017-01-09 10:13:46 [app] [I] Started PUT "/katello/api/repositories/4" for ::1 at 2017-01-09 10:13:46 -0500
2017-01-09 10:13:46 [app] [I] Processing by Katello::Api::V2::RepositoriesController#update as JSON
2017-01-09 10:13:46 [app] [I] Parameters: {"name"=>"foo_repo_cli_1", "url"=>"https://bar/foo/", "api_version"=>"v2", "id"=>"4", "repository"=>{"name"=>"foo_repo_cli_1", "url"=>"https://bar/foo/"}}
2017-01-09 10:13:46 [app] [I] Authorized user admin(Admin User)
2017-01-09 10:13:47 [app] [I] Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.92/app/views/katello/api/v2/repositories/show.json.rabl within katello/api/v2/layouts/resource (58.3ms)
2017-01-09 10:13:47 [app] [I] Completed 200 OK in 1584ms (Views: 23.5ms | ActiveRecord: 54.6ms)
actually - FAILEDQA: was looking into a wrong log file. The pulp still logs this into the syslog: Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) Traceback (most recent call last): Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 240, in trace_task Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) R = retval = fun(*args, **kwargs) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 473, in __call__ Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) return super(Task, self).__call__(*args, **kwargs) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 103, in __call__ Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) return super(PulpTask, self).__call__(*args, **kwargs) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/celery/app/trace.py", line 437, in __protected_call__ Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) return self.run(*args, **kwargs) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/distributor.py", line 211, in update Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) distributor.config.pop(k) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) File "/usr/lib/python2.7/site-packages/mongoengine/base/datastructures.py", line 73, in pop Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) return super(BaseDict, self).pop(*args, **kwargs) Jan 9 10:13:47 bkr-hv02-guest27 pulp: celery.worker.job:ERROR: (641-14912) KeyError: u'checksum_type' ..as a bonus, I'm no longer able to create new repos after this: Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) Exception adding importer to repo [ksvxWsZvER-uSkDmNwcJy-IJKiwmPEvU]; the repo will be deleted Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) Traceback (most recent call last): Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/repository.py", line 411, in create_repo Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) importer_controller.set_importer(repo_id, importer_type_id, importer_repo_plugin_config) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/celery/local.py", line 167, in <lambda> Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) __call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 473, in __call__ Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) return super(Task, self).__call__(*args, **kwargs) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/pulp/server/async/tasks.py", line 103, in __call__ Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) return super(PulpTask, self).__call__(*args, **kwargs) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/celery/app/task.py", line 420, in __call__ Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) return self.run(*args, **kwargs) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/importer.py", line 85, in set_importer Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) validate_importer_config(repo.repo_id, importer_type_id, repo_plugin_config) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) File "/usr/lib/python2.7/site-packages/pulp/server/controllers/importer.py", line 173, in validate_importer_config Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) raise exceptions.PulpCodedValidationException(validation_errors=message) Jan 10 11:44:17 bkr-hv02-guest27 pulp: pulp.server.controllers.repository:ERROR: (19882-31008) PulpCodedValidationException: A validation error occurred. I need a fresh sat6.2.7 installation to prove the latter is caused by this BZ. please disregard - I didn't notice this is ON_QA for 6.3.0 VERIFIED on sat6.3.0 snap#13 no traceback present anymore Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.
>
> For information on the advisory, and where to find the updated files, follow the link below.
>
> If the solution does not work for you, open a new bug report.
>
> https://access.redhat.com/errata/RHSA-2018:0336
|