Bug 1357397

Summary: Trash translator fails to create 'internal_op' directory under already existing trash directory
Product: [Community] GlusterFS Reporter: Jiffin <jthottan>
Component: trash-xlatorAssignee: Jiffin <jthottan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, anoopcs, bsrirama, bugs, jthottan, ravishankar, rhs-bugs, storage-qa-internal
Target Milestone: ---Keywords: ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1356804
: 1358262 1358268 (view as bug list) Environment:
Last Closed: 2016-08-20 05:26:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1356804    
Bug Blocks: 1358262, 1358268    

Comment 1 Vijay Bellur 2016-07-18 07:06:31 UTC 
REVIEW: http://review.gluster.org/14938 (xlator/trash : append '/' at the end in trash_notify_lookup_cbk) posted (#1) for review on master by jiffin tony Thottan (jthottan)
Comment 2 Vijay Bellur 2016-07-18 11:00:19 UTC 
REVIEW: http://review.gluster.org/14938 (xlator/trash : append '/' at the end in trash_notify_lookup_cbk) posted (#2) for review on master by jiffin tony Thottan (jthottan)
Comment 3 Vijay Bellur 2016-07-19 13:16:15 UTC 
COMMIT: http://review.gluster.org/14938 committed in master by Jeff Darcy (jdarcy) 
------
commit d90307c1b0245e0e6a39044a28819cde520a100c
Author: Jiffin Tony Thottan <jthottan>
Date:   Mon Jul 18 11:12:43 2016 +0530

    xlator/trash : append '/' at the end in trash_notify_lookup_cbk
    
    In the notify function in trash xlator, a lookup is performed
    to obtain path of old trash directory. The result usually contains
    path without '/' at the end. The trash xlator maintains expects
    '/' at the end for the values such as 'old trash dir' and
    'new trash dir'. Otherwise certian checks in the code will fail.
    
    Change-Id: I89e02e4b249314fb6536297f959865feee182c83
    BUG: 1357397
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/14938
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Anoop C S <anoopcs>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>