Bug 1357421

Summary: Fail smoke tests if cherry-picked bugs contain the old git-tags
Product: [Community] GlusterFS Reporter: Niels de Vos <ndevos>
Component: project-infrastructureAssignee: bugs <bugs>
Status: CLOSED UPSTREAM QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: bugs, gluster-infra
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-12 12:51:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Niels de Vos 2016-07-18 07:51:02 UTC
Description of problem:
The commit message of patches should not have incorrect tags. This is common to see when backports are done through the Gerrit webui. Many seem to ignore the http://gluster.readthedocs.io/en/latest/Developer-guide/Backport-Guidelines/ where it is clearly mentioned what changes to the commit message are required.

Backports may rely on other changes, or may have been modified in order to match the older version of the code. Keeping the git-tags from the backported patch is suggested, but indention is required to make the distinction between the old and the new (inserted by Gerrit on merging) onced.

Version-Release number of selected component (if applicable):
all

How reproducible:
Backport a change without taking the Backport Guidelines into account.


Actual results:
For example http://review.gluster.org/#/c/13863/1

Expected results:
http://review.gluster.org/#/c/13863/2

Additional info:
A new Jenkins job that is part of the smoke test would do. The following git-tags in the commit message should be prohibited:

Reviewed-on:
Smoke:
CentOS-regression:
NetBSD-regression:

A basic script that fails when the commit message contains any of these:

MATCHES=$(git log -1 --format=email | grep -c \
    -e '^Reviewed-on:' \
    -e '^Smoke:' \
    -e '^CentOS-regression:' \
    -e '^NetBSD-regression:')

exit ${MATCHES}

Comment 2 Worker Ant 2020-03-12 12:51:22 UTC
This bug is moved to https://github.com/gluster/project-infrastructure/issues/23, and will be tracked there from now on. Visit GitHub issues URL for further details