Bug 1357876 (psysh)

Summary: Review Request: psysh - A runtime developer console, interactive debugger and REPL for PHP
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-28 23:52:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1357873, 1357875    
Bug Blocks: 1357097    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2016-07-19 12:54:15 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/0a2a1552bffbda9d50cb1ae24cf86de10a8c388f/psysh/psysh.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/psysh-0.7.2-1.fc24.src.rpm

Description: A runtime developer console, interactive debugger and REPL for PHP.

Fedora Account System Username: siwinski

Comment 1 Remi Collet 2016-07-20 12:46:50 UTC
Created attachment 1182108 [details]
phpci.log

phpCompatInfo version 5.0.1 DB version 1.10.0 built Jul 05 2016 07:54:25 CEST

Comment 2 Remi Collet 2016-07-20 12:47:26 UTC
Created attachment 1182109 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -L /dev/shm/extras/RPMS/noarch/ -b 1357876
Buildroot used: fedora-rawhide-x86_64

Comment 3 Remi Collet 2016-07-20 12:48:17 UTC
[!]: Requires correct, justified where necessary.
	As you keep default shebang (/usr/bin/env php)
	you need to require php-cli (pulled by php-readline, so not a blocker)


Minor issue, not a blocker, please fix during import


==== APPROVED ====

Comment 4 Gwyn Ciesla 2016-07-20 13:24:20 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/psysh

Comment 5 Shawn Iwinski 2016-07-20 13:38:41 UTC
(In reply to Remi Collet from comment #3)
> [!]: Requires correct, justified where necessary.
> 	As you keep default shebang (/usr/bin/env php)
> 	you need to require php-cli (pulled by php-readline, so not a blocker)

Good catch!

THANKS for the review!

Comment 6 Fedora Update System 2016-07-21 13:33:52 UTC
psysh-0.7.2-2.fc24 php-jakub-onderka-php-console-highlighter-0.3.2-1.fc24 php-jakub-onderka-php-console-color-0.1-1.fc24 php-dnoegel-php-xdg-base-dir-0.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-92ad6b2778

Comment 7 Fedora Update System 2016-07-21 13:34:14 UTC
psysh-0.7.2-2.fc23 php-jakub-onderka-php-console-highlighter-0.3.2-1.fc23 php-jakub-onderka-php-console-color-0.1-1.fc23 php-dnoegel-php-xdg-base-dir-0.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-72679143c8

Comment 8 Fedora Update System 2016-07-21 13:34:28 UTC
psysh-0.7.2-2.el7 php-jakub-onderka-php-console-highlighter-0.3.2-1.el7 php-jakub-onderka-php-console-color-0.1-1.el7 php-dnoegel-php-xdg-base-dir-0.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-329fcf139c

Comment 9 Fedora Update System 2016-07-21 18:48:15 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.fc23, php-jakub-onderka-php-console-color-0.1-1.fc23, php-jakub-onderka-php-console-highlighter-0.3.2-1.fc23, psysh-0.7.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-72679143c8

Comment 10 Fedora Update System 2016-07-21 18:51:59 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.fc24, php-jakub-onderka-php-console-color-0.1-1.fc24, php-jakub-onderka-php-console-highlighter-0.3.2-1.fc24, psysh-0.7.2-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-92ad6b2778

Comment 11 Fedora Update System 2016-07-21 23:48:14 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.el7, php-jakub-onderka-php-console-color-0.1-1.el7, php-jakub-onderka-php-console-highlighter-0.3.2-1.el7, psysh-0.7.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-329fcf139c

Comment 12 Fedora Update System 2016-07-28 23:52:33 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.fc24, php-jakub-onderka-php-console-color-0.1-1.fc24, php-jakub-onderka-php-console-highlighter-0.3.2-1.fc24, psysh-0.7.2-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-07-29 02:50:52 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.fc23, php-jakub-onderka-php-console-color-0.1-1.fc23, php-jakub-onderka-php-console-highlighter-0.3.2-1.fc23, psysh-0.7.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-08-08 21:18:05 UTC
php-dnoegel-php-xdg-base-dir-0.1-1.el7, php-jakub-onderka-php-console-color-0.1-1.el7, php-jakub-onderka-php-console-highlighter-0.3.2-1.el7, psysh-0.7.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.