Bug 1358197

Hmm, I bet if you re-ran the upgrade playbook it'd add it? I think this is happening because docker may not have been upgraded prior to updating the unit files. I'm not certain though. I'll look into it.

I can no longer reproduce this due to recent changes to our upgrade process. Can QE? I'll try a few more times but moving this to ON_QA

The bug is still exist.  To reproduce that you must install OSE 3.2 using old version of openshift-ansible.

The atomic-openshift-node wasn't reload https://bugzilla.redhat.com/show_bug.cgi?id=1371004

(In reply to Anping Li from comment #3)
> The bug is still exist.  To reproduce that you must install OSE 3.2 using
> old version of openshift-ansible.

Ok, I went back to openshift-ansible-3.2.10-1 which didn't have the rslave flag, i verified that the unit didn't have that. I performed an upgrade using the latest in enterprise-3.2 branch, the rslave flag gets added, however the unit is not reloaded.

Does that mirror the behavior you're seeing? So if bug 1371004 is fixed then this bug will also be fixed, correct?

Let me know if you're not actually seeing /etc/systemd/system/atomic-openshift-node.service updated and if so, which version of the installer did you use to do the clean install and which version did you use to perform the upgrade?

@Scott, Yes, the /etc/systemd/system/atomic-openshift-node.service updated  have been updated. it will take affect once the bug 1371004 is fixed.

@Scott, Please ignore the comment 6, there are no rslave in /etc/systemd/system/atomic-openshift-node.service after upgraded.

[root@anli-working data]# diff pre_migrate_1472527608/host6node.example.com/etc/systemd/system/atomic-openshift-node.service post_migrate_1472527608/host6node.example.com/etc/systemd/system/atomic-openshift-node.service 
16c16
< ExecStart=/usr/bin/docker run --name atomic-openshift-node --rm --privileged --net=host --pid=host --env-file=/etc/sysconfig/atomic-openshift-node -v /:/rootfs:ro -e CONFIG_FILE=${CONFIG_FILE} -e OPTIONS=${OPTIONS} -e HOST=/rootfs -e HOST_ETC=/host-etc -v /var/lib/origin:/var/lib/origin -v /etc/origin/node:/etc/origin/node -v /etc/localtime:/etc/localtime:ro -v /etc/machine-id:/etc/machine-id:ro -v /run:/run -v /sys:/sys:ro -v /usr/bin/docker:/usr/bin/docker:ro -v /var/lib/docker:/var/lib/docker -v /lib/modules:/lib/modules -v /etc/origin/openvswitch:/etc/openvswitch -v /etc/origin/sdn:/etc/openshift-sdn -v /etc/systemd/system:/host-etc/systemd/system -v /var/log:/var/log -v /dev:/dev $DOCKER_ADDTL_BIND_MOUNTS openshift3/node:${IMAGE_VERSION}
---
> ExecStart=/usr/bin/docker run --name atomic-openshift-node --rm --privileged --net=host --pid=host --env-file=/etc/sysconfig/atomic-openshift-node -v /:/rootfs:ro -e CONFIG_FILE=${CONFIG_FILE} -e OPTIONS=${OPTIONS} -e HOST=/rootfs -e HOST_ETC=/host-etc -v /var/lib/origin:/var/lib/origin -v /etc/origin/node:/etc/origin/node -v /etc/localtime:/etc/localtime:ro -v /etc/machine-id:/etc/machine-id:ro -v /run:/run -v /sys:/sys:rw -v /usr/bin/docker:/usr/bin/docker:ro -v /var/lib/docker:/var/lib/docker -v /lib/modules:/lib/modules -v /etc/origin/openvswitch:/etc/openvswitch -v /etc/origin/sdn:/etc/openshift-sdn -v /etc/systemd/system:/host-etc/systemd/system -v /var/log:/var/log -v /dev:/dev $DOCKER_ADDTL_BIND_MOUNTS openshift3/node:${IMAGE_VERSION}

Created attachment 1195618 [details]
Upgrade logs

Before upgrade, docker version is 1.9.1

https://github.com/openshift/openshift-ansible/pull/2387 proposed PR, needs quick review though, will merge tomorrow.

The bug wasn't fixed in atomic-openshift-utils-3.2.25

Sorry, this too wasn't fixed until 3.2.27. latest is openshift-ansible-3.2.28-1.git.0.5a85fc5.el7

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2016:1853