Bug 1358248
| Summary: | Review Request: python-http-client - HTTP REST client, simplified for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominika Krejčí <dkrejci> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ignatenko, package-review |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-08 20:29:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1309244 | ||
|
Description
Dominika Krejčí
2016-07-20 10:46:31 UTC
> %global sum HTTP REST client, simplified for Python put to Summary tag and reuse further as %{summary} > %autosetup -n %{name}-%{version} jsut %autosetup > %{python3_sitelib}/python_http_client* too relax (actually you have 2 same lines, with glob and without). it's always better to be more precised * No pythonX-setuptools BR, guess it's missing * Reuse %{url} in Source tag * add "-v" to py.test invocation (useful when some test fails) * do %global _description and reuse from descriptions. Also add "Python X version." for each subpackage to easily identify without name where it belongs to. * Move BuildRequires under subpackages for better look&feel Thank you for comments. Everything should be fixed. Spec URL: https://dkrejci.fedorapeople.org/python-http-client/python-http-client.spec SRPM URL: https://dkrejci.fedorapeople.org/python-http-client/python-http-client-2.1.1-1.fc24.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14958315 Nothing else what I could complain about. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-http-client python-http-client-2.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-10f3138a48 python-http-client-2.1.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3706299c18 python-http-client-2.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-10f3138a48 python-http-client-2.1.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3706299c18 python-http-client-2.1.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-http-client-2.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |