Bug 1358255

Summary: unlogical appearance of ' Hosted Engine upgrade failed: this system is not reliable.'
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Jiri Belka <jbelka>
Component: GeneralAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: high Docs Contact:
Priority: medium    
Version: 2.0.0.1CC: bugs, sbonazzo, ylavi
Target Milestone: ovirt-4.0.2Flags: rule-engine: ovirt-4.0.z+
rule-engine: exception+
rule-engine: planning_ack+
sbonazzo: devel_ack+
gklein: testing_ack+
Target Release: 2.0.1.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Making the exit message context aware: using softer exit messages if the error occured before the tool really touched the system.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-17 14:44:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Belka 2016-07-20 11:36:37 UTC
Description of problem:

sometimes appearance of '[ ERROR ] Hosted Engine upgrade failed: this system is not reliable. If necessary you can use --rollback-upgrade option to recover the engine VM disk from a backup' doesn't make sense.

An example:

~~~
...
[ INFO  ] Checking SPM status on this host
[ INFO  ] Connecting to the Engine
[ ERROR ] This host is not the SPM one, please select it as the SPM from the engine or run this tool on the SPM host.
[ ERROR ] Failed to execute stage 'Environment customization': Cannot run the upgrade tool if the host is not the SPM
[ INFO  ] Stage: Clean up
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Hosted Engine upgrade failed: this system is not reliable. If necessary you can use --rollback-upgrade option to recover the engine VM disk from a backup
          Log file is located at /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-20160720133011-zv4u3f.log
~~~

Thus there was no upgrade at all but the setup after it fails tells me the env is unstable and do '--rollback-upgrade' even no such upgrade has been practically started.

Please review under which circumstences this message appear.

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-2.0.1-1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. rhevh 3.6 legacy with HE (whole env is up and fine)
2. add redhat-virtualization-host (aka NGN) as another host of SHE env
3. migrate HE VM to 'NGN' host (ensure old host is still SPM)
4. global maintenance
5. hosted-engine --upgrade-appliance

Actual results:
setup fails as current host (where hosted-engine --upgrade-appliance was executed) is not SPM but then it displays unlogical message

Expected results:
do not display this message if the setup has not practically migrated the SHE env

Additional info:

Comment 3 Jiri Belka 2016-08-17 10:17:26 UTC
ok, ovirt-hosted-engine-setup-2.0.1.4-1.el7ev.noarch

looks good, tested on non-SPM and with non global maintenance mode

[ INFO  ] Connecting to the Engine
[ ERROR ] This host is not the SPM one, please select it as the SPM from the engine or run this tool on th
e SPM host.
[ ERROR ] Failed to execute stage 'Environment customization': Cannot run the upgrade tool if the host is 
not the SPM
[ INFO  ] Stage: Clean up
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Hosted Engine upgrade failed
          Log file is located at /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-201608171215
42-bb8k6s.log