Bug 1358692

Summary: Review Request: golang-github-mvo5-uboot-go - Read/write uboot environment
Product: [Fedora] Fedora Reporter: Zygmunt Krynicki <me>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: admiller, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-01 16:27:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zygmunt Krynicki 2016-07-21 09:46:26 UTC
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/zyga/snapcore/golang-github-mvo5-uboot-go.git/plain/golang-github-mvo5-uboot-go.spec?h=f24

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/zyga/snapcore/fedora-24-x86_64/00400347-golang-github-mvo5-uboot-go/golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc24.src.rpm

Description: 
Small go package/app to read/write uboot env files that contain crc32 + 1 byte
padding. Unlike fw_{set,print}env it does not needs a /etc/fw_env.config config
file.

Fedora Account System Username: zyga

Comment 1 Neal Gompa 2016-07-21 09:51:40 UTC
While this needs a sponsor to ultimately be approved, I will go ahead with reviewing this.

Comment 2 Neal Gompa 2016-07-21 10:14:30 UTC
Package was generated through gofed, so this review is quite a bit simpler.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- only sources installed

Package approved.

Comment 3 Adam Miller 2016-07-21 15:39:54 UTC
I've sponsored zyga into the packager group in FAS. You can now make the pkgdb SCM request.

Comment 4 Gwyn Ciesla 2016-07-21 17:47:01 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-mvo5-uboot-go

Comment 5 Fedora Update System 2016-07-22 07:16:02 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4154def2ea

Comment 6 Fedora Update System 2016-07-22 07:23:57 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6820c54b1

Comment 7 Fedora Update System 2016-07-22 19:21:05 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6820c54b1

Comment 8 Fedora Update System 2016-07-22 19:21:09 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4154def2ea

Comment 9 Fedora Update System 2016-08-01 16:27:32 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-08-01 18:53:07 UTC
golang-github-mvo5-uboot-go-0-0.1.git361f6eb.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.