Bug 1358940

Summary: Review Request: perl-DBICx-Sugar - Just some syntax sugar for DBIx::Class
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-13 11:10:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2016-07-21 20:15:34 UTC 
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBICx-Sugar/perl-DBICx-Sugar.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBICx-Sugar/perl-DBICx-Sugar-0.0001-1.fc24.src.rpm
Description:
Just some syntax sugar for your DBIx::Class applications. This was
originally created to remove code duplication between Dancer::Plugin::DBIC
and Dancer2::Plugin::DBIC.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 1 Jitka Plesnikova 2016-07-22 15:03:02 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-DBICx-Sugar-0.0001-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(Memoize)
      1 perl(Module::Load)
      1 perl(YAML)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-DBICx-Sugar-0.0001-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(DBICx::Sugar) = 0.0001
      1 perl-DBICx-Sugar = 0.0001-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-DBICx-Sugar*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved
Comment 2 Emmanuel Seyman 2016-07-24 12:07:40 UTC 
Repo requested. Thanks for the review, Jikta.
Comment 3 Gwyn Ciesla 2016-07-24 16:26:07 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-DBICx-Sugar
Comment 4 Emmanuel Seyman 2016-08-13 11:10:39 UTC 
This package has been imported in Fedora and updates have been issued for the currently supported versions of Fedora.