Bug 1359495

Summary: Review Request: perl-Data-Dump-Streamer - Accurately serialize a data structure as Perl code
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-27 10:23:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Paul Howarth 2016-07-24 09:32:18 UTC 
Spec URL: http://www.city-fan.org/~paul/extras/perl-Data-Dump-Streamer/perl-Data-Dump-Streamer.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Data-Dump-Streamer/perl-Data-Dump-Streamer-2.39-1.fc25.src.rpm

Description:
Given a list of scalars or reference variables, writes out their contents
in perl syntax. The references can also be objects. The contents of each
variable is output using the least number of Perl statements as convenient,
usually only one. Self-referential structures, closures, and objects are
output correctly.

Fedora Account System Username: pghmcfc

This is a re-review for a previously-retired package, retired because it FTBFS with Perl 5.22. This has now been fixed upstream, and there's no issue with Perl 5.24 either.
Comment 1 Petr Pisar 2016-07-28 12:31:26 UTC 
URL and Source0 and Patch0 addresses are usable. Ok.
Source archive is original (SHA-256: 3b03763f527bfd27deae7912735a5edfd50627af7dece852505cc791a596a6c4). Ok.
Patch0 is original (SHA-256: e47eb8e281c915dcee8e21b008c7f08311ac131b0bec64383c47c920d3b097f2). Ok.
The patch is good. Ok.
Summary verified from lib/Data/Dump/Streamer.pm. Ok.
Description verified from lib/Data/Dump/Streamer.pm. Ok.
License verified from lib/Data/Dump/Streamer.pm, lib/Data/Dump/ppport.h, lib/Data/Dump/Streamer.xs, README. Ok.
XS code exist, architecture dependent package is Ok.

FIX: Build-require `perl(re)' (lib/Data/Dump/Streamer.pm:132).

TODO: Constrain `perl(ExtUtils::Depends)' dependency with `>= 0.302' (inc/My/Builder.pm:24) or constrain `perl(B::Utils)' build-require with `>= 0.05' (inc/My/Builder.pm:17).

All tests pass. Ok.

$ rpmlint perl-Data-Dump-Streamer.spec ../SRPMS/perl-Data-Dump-Streamer-2.39-1.fc26.src.rpm ../RPMS/x86_64/perl-Data-Dump-Streamer-*
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Data-Dump-Streamer-2.39-1.fc26.x86_64.rpm 
-rw-r--r--    1 root    root                      385 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/DDS.pm
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data/Dump
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data/Dump/Streamer
-rw-r--r--    1 root    root                   130974 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data/Dump/Streamer.pm
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data/Dump/Streamer/_
-rw-r--r--    1 root    root                     1221 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/Data/Dump/Streamer/_/Printers.pm
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/auto/Data
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/auto/Data/Dump
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/auto/Data/Dump/Streamer
-rwxr-xr-x    1 root    root                    32320 Jul 28 14:19 /usr/lib64/perl5/vendor_perl/auto/Data/Dump/Streamer/Streamer.so
drwxr-xr-x    2 root    root                        0 Jul 28 14:19 /usr/share/doc/perl-Data-Dump-Streamer
-rw-r--r--    1 root    root                    10105 Dec 24  2015 /usr/share/doc/perl-Data-Dump-Streamer/Changes
-rw-r--r--    1 root    root                     1113 Dec 24  2015 /usr/share/doc/perl-Data-Dump-Streamer/README
-rw-r--r--    1 root    root                     1889 Jul 28 14:19 /usr/share/man/man3/DDS.3pm.gz
-rw-r--r--    1 root    root                    16614 Jul 28 14:19 /usr/share/man/man3/Data::Dump::Streamer.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Data-Dump-Streamer-2.39-1.fc26.x86_64.rpm | sort -f | uniq -c 
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(B)
      1 perl(B::Deparse)
      1 perl(B::Utils)
      1 perl(Compress::Zlib)
      1 perl(Data::Dump::Streamer)
      1 perl(Data::Dumper)
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl(IO::File)
      1 perl(MIME::Base64)
      1 perl(overload)
      1 perl(PadWalker) >= 0.99
      1 perl(strict)
      1 perl(Symbol)
      1 perl(Text::Abbrev)
      1 perl(Text::Balanced)
      1 perl(utf8)
      1 perl(vars)
      1 perl(warnings)
      1 perl(warnings::register)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
FIX: Run-require `perl(bytes)' (lib/Data/Dump/Streamer.pm:841).
FIX: Run-require `perl(re)' (lib/Data/Dump/Streamer.pm:132).

$ rpm -q --provides -p ../RPMS/x86_64/perl-Data-Dump-Streamer-2.39-1.fc26.x86_64.rpm | sort -f | uniq -c 
      1 perl(Data::Dump::Streamer) = 2.39
      1 perl(Data::Dump::Streamer::Deparser) = 2.39
      1 perl-Data-Dump-Streamer = 2.39-1.fc26
      1 perl-Data-Dump-Streamer(x86-64) = 2.39-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Data-Dump-Streamer-2.39-1.fc26.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package buils in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15048260). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items and consider fixing `TODO' items before building this package.
Comment 2 Paul Howarth 2016-07-28 13:19:59 UTC 
Issues addressed in -2:

Spec URL: http://www.city-fan.org/~paul/extras/perl-Data-Dump-Streamer/perl-Data-Dump-Streamer.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Data-Dump-Streamer/perl-Data-Dump-Streamer-2.39-2.fc26.src.rpm

I guess I'm relying too much on tangerine.
Comment 3 Igor Gnatenko 2016-08-14 15:47:54 UTC 
Paul, please request package in PkgDB and proceed.
Comment 4 Paul Howarth 2016-08-15 07:50:34 UTC 
(In reply to Igor Gnatenko from comment #3)
> Paul, please request package in PkgDB and proceed.

I already did. I've been waiting over a week for my rel-eng request to get the package unblocked in koji:

https://fedorahosted.org/rel-eng/ticket/6454
Comment 5 Fedora Update System 2016-08-18 08:34:03 UTC 
perl-Data-Dump-Streamer-2.39-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8dcf3328a9
Comment 6 Fedora Update System 2016-08-18 08:34:11 UTC 
perl-Data-Dump-Streamer-2.39-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8462c420
Comment 7 Fedora Update System 2016-08-18 08:34:16 UTC 
perl-Data-Dump-Streamer-2.39-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7cc91ad2a
Comment 8 Fedora Update System 2016-08-18 16:54:19 UTC 
perl-Data-Dump-Streamer-2.39-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8dcf3328a9
Comment 9 Fedora Update System 2016-08-19 00:23:35 UTC 
perl-Data-Dump-Streamer-2.39-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3a8462c420
Comment 10 Fedora Update System 2016-08-19 00:59:33 UTC 
perl-Data-Dump-Streamer-2.39-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c7cc91ad2a
Comment 11 Fedora Update System 2016-08-27 10:23:15 UTC 
perl-Data-Dump-Streamer-2.39-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2016-08-27 15:18:35 UTC 
perl-Data-Dump-Streamer-2.39-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2016-08-27 20:51:06 UTC 
perl-Data-Dump-Streamer-2.39-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.