Bug 1359816

Summary: With capsule scenario plugin options are hard to guess
Product: Red Hat Satellite Reporter: Lukas Pramuk <lpramuk>
Component: InstallationAssignee: Martin Bacovsky <mbacovsk>
Status: CLOSED NEXTRELEASE QA Contact: Lukas Pramuk <lpramuk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, bkearney, cwelton, ehelms, jhutar, lpramuk, lzap, mbacovsk, mhulan, psuriset, stbenjam
Target Milestone: UnspecifiedKeywords: Reopened, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1339336 Environment:
Last Closed: 2017-09-22 12:14:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1339336    
Bug Blocks:    

Comment 1 Lukas Pramuk 2016-07-25 13:53:54 UTC
for example remote execution plugin:

@Satellite
= Module foreman_proxy_plugin_remote_execution_ssh:
    --foreman-proxy-plugin-remote-execution-ssh-enabled  Enables/disables the plugin (default: true)
    --foreman-proxy-plugin-remote-execution-ssh-generate-keys  Automatically generate SSH keys (default: true)
    --foreman-proxy-plugin-remote-execution-ssh-listen-on  Proxy feature listens on https, http, or both (default: "https")
    --foreman-proxy-plugin-remote-execution-ssh-local-working-dir  Local working directory on the smart proxy (default: "/var/tmp")
    --foreman-proxy-plugin-remote-execution-ssh-remote-working-dir  Remote working directory on clients (default: "/var/tmp")
    --foreman-proxy-plugin-remote-execution-ssh-ssh-identity-dir  Directory where SSH keys are stored (default: "/usr/share/foreman-proxy/.ssh")
    --foreman-proxy-plugin-remote-execution-ssh-ssh-identity-file  Provide an alternative name for the SSH keys (default: "id_rsa_foreman_proxy")
    --foreman-proxy-plugin-remote-execution-ssh-ssh-keygen  Location of the ssh-keygen binary (default: "/usr/bin/ssh-keygen")

vs.


@Capsule
= Module foreman_proxy_plugin_remote_execution_ssh:
    --enabled                     enables/disables the plugin (default: true)
    --enabled                     enables/disables the pulp plugin (default: false)
    --enabled                     Enables/disables the plugin (default: true)
    --generate-keys               Automatically generate SSH keys (default: true)
    --listen-on                   Proxy feature listens on http, https, or both (default: "https")
    --listen-on                   Proxy feature listens on http, https, or both (default: "https")
    --listen-on                   Proxy feature listens on https, http, or both (default: "https")
    --local-working-dir           Local working directory on the smart proxy (default: "/var/tmp")
    --remote-working-dir          Remote working directory on clients (default: "/var/tmp")
    --ssh-identity-dir            Directory where SSH keys are stored (default: "/usr/share/foreman-proxy/.ssh")
    --ssh-identity-file           Provide an alternative name for the SSH keys (default: "id_rsa_foreman_proxy")
    --ssh-keygen                  Location of the ssh-keygen binary (default: "/usr/bin/ssh-keygen")

>>> we don't want our customers to guess correct plugin options by replacing _ with - and prepending -- and concating with the rest 

>>> --enabled listed 3 times and notice the funny part (default: true) vs. (default: false)

Comment 2 Bryan Kearney 2016-07-25 14:17:25 UTC
Upstream bug assigned to mbacovsk

Comment 3 Bryan Kearney 2016-07-25 14:17:29 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/13908 has been closed

Comment 4 Lukas Pramuk 2016-07-25 14:17:44 UTC
It looks like we are having plugin option conflicts here:

# satellite-installer --enabled blah
Parameter enabled invalid
Parameter enabled invalid
Parameter enabled invalid
Error during configuration, exiting

>> 3 plugins are consuming the same option (--enabled)

# satellite-installer --listen-on .
Parameter listen-on invalid
Parameter listen-on invalid
Error during configuration, exiting

>> 2 plugins are consuming the same option (--listen-on)

Comment 8 Stephen Benjamin 2016-08-01 18:49:12 UTC

*** This bug has been marked as a duplicate of bug 1352003 ***

Comment 9 Stephen Benjamin 2016-08-01 18:50:17 UTC
Ah sorry not a dupe - I misread the description it was cloned from.