Bug 1359820
| Summary: | Review Request: python-cloudkittyclient - Client library for CloudKitty | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Haïkel Guémar <karlthered> |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jruzicka, mrunge, package-review |
| Target Milestone: | --- | Flags: | karlthered:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-27 23:22:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1329341 | ||
|
Description
Haïkel Guémar
2016-07-25 13:50:12 UTC
Could not download Source0: http://tarballs.openstack.org/python-cloudkittyclient/python-cloudkittyclient/python-cloudkittyclient-0.5.0.tar.gz Possibly relevant rpmlint warnings: ----------------------------------- python2-cloudkittyclient.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.buildinfo python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.doctrees Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[s]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[s]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
generated", "*No copyright* Apache (v2.0)". 28 files have unknown
license. Detailed output of licensecheck in /home/mrunge/1359820
-python-cloudkittyclient/licensecheck.txt
[s]: License file installed when any subpackage combination is installed.
[s]: Package contains no bundled libraries without FPC exception.
[s]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
False report
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0: http://tarballs.openstack.org
/python-cloudkittyclient/python-cloudkittyclient/python-
cloudkittyclient-0.5.0.tar.gz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-cloudkittyclient , python3-cloudkittyclient
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-cloudkittyclient-0.5.0-2.fc26.noarch.rpm
python3-cloudkittyclient-0.5.0-2.fc26.noarch.rpm
python-cloudkittyclient-doc-0.5.0-2.fc26.noarch.rpm
python-cloudkittyclient-0.5.0-2.fc26.src.rpm
python2-cloudkittyclient.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-2.7
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-2
python3-cloudkittyclient.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python3-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-3
python3-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-3.5
python-cloudkittyclient-doc.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.buildinfo
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.doctrees
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.doctrees
python-cloudkittyclient.src: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python-cloudkittyclient.src: W: invalid-url Source0: http://tarballs.openstack.org/python-cloudkittyclient/python-cloudkittyclient/python-cloudkittyclient-0.5.0.tar.gz HTTP Error 404: Not Found
4 packages and 0 specfiles checked; 0 errors, 13 warnings.
Rpmlint (installed packages)
----------------------------
python2-cloudkittyclient.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-2
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-2.7
python2-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty
python3-cloudkittyclient.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python3-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-3
python3-cloudkittyclient.noarch: W: no-manual-page-for-binary cloudkitty-3.5
python-cloudkittyclient-doc.noarch: W: invalid-url URL: http://launchpad.net/python-cloudkittyclient/ HTTP Error 404: Not Found
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.buildinfo
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.doctrees
python-cloudkittyclient-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-cloudkittyclient-doc/html/.doctrees
3 packages and 0 specfiles checked; 0 errors, 11 warnings.
Requires
--------
python2-cloudkittyclient (rpmlib, GLIBC filtered):
/usr/bin/python2
python(abi)
python-babel
python-keystoneclient
python-oslo-i18n
python-oslo-serialization
python-oslo-utils
python-pbr
python-prettytable
python-stevedore
python3-cloudkittyclient (rpmlib, GLIBC filtered):
/usr/bin/python3
python(abi)
python3-babel
python3-keystoneclient
python3-oslo-i18n
python3-oslo-serialization
python3-oslo-utils
python3-pbr
python3-prettytable
python3-stevedore
python-cloudkittyclient-doc (rpmlib, GLIBC filtered):
python-cloudkittyclient
Provides
--------
python2-cloudkittyclient:
python-cloudkittyclient
python2-cloudkittyclient
python2.7dist(python-cloudkittyclient)
python2dist(python-cloudkittyclient)
python3-cloudkittyclient:
python3-cloudkittyclient
python3.5dist(python-cloudkittyclient)
python3dist(python-cloudkittyclient)
python-cloudkittyclient-doc:
python-cloudkittyclient-doc
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1359820
Buildroot used: fedora-rawhide-armhfp
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Approved by mrunge, this was imported and stuff. |