Bug 1360119
| Summary: | Fail to edit the guest's XML associated with a saved state file with virsh save-image-edit command | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | yisun |
| Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> |
| Status: | CLOSED DUPLICATE | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.3 | CC: | abologna, berrange, dyuan, eblake, gsun, mzhan, rbalakri, virt-bugs, yisun, zhwang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1229255 | Environment: | |
| Last Closed: | 2016-07-27 02:45:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1229255 | ||
| Bug Blocks: | |||
|
Comment 1
yisun
2016-07-26 04:37:58 UTC
(In reply to yisun from comment #1) > per https://bugzilla.redhat.com/show_bug.cgi?id=1229255#c10 > This issue also reproduced on x86_64 platform(which doesn't have problem > before), so clone this bug here for tracking. Does it make sense to have two separate bugs track this? Wouldn't it be less confusing to just move Bug 1229255 to Hardware: All and keep tracking the issue there? Guannan mentioned that a new bug was filed because this issue didn't seem to affect libvirt < 2.0.0 on x86. I actually think that there has been no regression on x86, and that the bug was affecting both architectures even before; what might have happened is that the bug has been made easier to trigger because the domain XML has become bigger on x86. It would be very interesting to take the domain XML from libvirt 2.0.0 and use it to define a guest on earlier libvirt, and see whether performing the same steps on both libvirt versions has the same result. (In reply to Andrea Bolognani from comment #4) > Guannan mentioned that a new bug was filed because this issue > didn't seem to affect libvirt < 2.0.0 on x86. > > I actually think that there has been no regression on x86, > and that the bug was affecting both architectures even before; > what might have happened is that the bug has been made easier > to trigger because the domain XML has become bigger on x86. > > It would be very interesting to take the domain XML from > libvirt 2.0.0 and use it to define a guest on earlier libvirt, > and see whether performing the same steps on both libvirt > versions has the same result. Your assumption is correct, with same xml, it reproduced on previous libvirt versions. I'll close this bug, add comment to original bug and change the "platform" from "ppc" to "all". thx. ============ libvirt-1.2.17-13.el7.x86_64 ============ [root@localhost 1.2.17-13.el7]# service libvirtd restart Redirecting to /bin/systemctl restart libvirtd.service [root@localhost 1.2.17-13.el7]# rpm -qa | grep libvirt-1 libvirt-1.2.17-13.el7.x86_64 [root@localhost 1.2.17-13.el7]# rpm -qa | grep libvirt-1^C [root@localhost 1.2.17-13.el7]# virsh save-image-edit /tmp/vm.save error: operation failed: new xml too large to fit in file Failed. Try again? [y,n,f,?]: error: operation failed: new xml too large to fit in file [root@localhost 1.2.17-13.el7]# virsh save-image-define /tmp/vm.save /tmp/old_vm.xml --running error: Failed to update /tmp/vm.save error: operation failed: new xml too large to fit in file ============ libvirt-1.3.5-1.el7.x86_64 ============ [root@localhost 1.3.5-1.el7]# rpm -qa | grep libvirt-1 libvirt-1.3.5-1.el7.x86_64 [root@localhost 1.3.5-1.el7]# service libvirtd restart Redirecting to /bin/systemctl restart libvirtd.service [root@localhost 1.3.5-1.el7]# virsh save-image-edit /tmp/vm.save error: operation failed: new xml too large to fit in file Failed. Try again? [y,n,f,?]: error: operation failed: new xml too large to fit in file [root@localhost 1.3.5-1.el7]# vim /tmp/old_vm.xml [root@localhost 1.3.5-1.el7]# virsh save-image-define /tmp/vm.save /tmp/old_vm.xml --running error: Failed to update /tmp/vm.save error: operation failed: new xml too large to fit in file *** This bug has been marked as a duplicate of bug 1229255 *** |