Bug 1360274

Summary:	Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
Product:	[Fedora] Fedora	Reporter:	Helio Chissini de Castro <helio>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-01 14:54:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	928937

Description Helio Chissini de Castro 2016-07-26 11:48:21 UTC

Spec URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyboard.spec
SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyboard-5.7.0-1.fc24.src.rpm
Description: The Qt Virtual Keyboard project provides an input framework and reference keyboard frontend
for Qt 5 on Linux Desktop/X11, Windows Desktop, and Boot2Qt targets.
The input framework makes it easy to write custom input methods or to
integrate 3rd party input engines. The input methods can be implemented in C++ or QML.
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2016-07-26 12:48:17 UTC

I can review today

Comment 2 Rex Dieter 2016-07-26 13:07:02 UTC

naming: ok

macros: ok

scriptlets: ok

sources: ok
fa473ab9175483dd82aa4d27b9682715  qtvirtualkeyboard-opensource-src-5.7.0.tar.xz

licensing: ok

dependencies: mostly ok

1. SHOULD: I see:
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
but no matching
BuildRequires: qt5-qtbase-private-devel
(which is what we currently use to easily track these hard versioned dependencies).  Please add that

 
Otherwise, relatively simple package, matches conventions and style of other existing qt5 packages.

APPROVED.

Comment 3 Gwyn Ciesla 2016-07-26 13:33:31 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5-qtvirtualkeyboard

Comment 4 Rex Dieter 2016-08-01 14:54:54 UTC

imported and built for rawhide