Bug 1360365
| Summary: | Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Enselme <jujens> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-09-05 17:52:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Julien Enselme
2016-07-26 14:02:26 UTC
%{sum} macro is not necessary, you can write Summary: normally first time, and then use Summary: %{summary} for the subsequent ones.
You don't need to actually delete .egg-info.
+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ standard python packaging is used
+ python_provide is used
+ no scriptlets present or necessary
- builds and installs OK
? P/R/BR look OK
%check fails in mock, looks like you need BR's on mock too.
----------------------------- Captured stderr call -----------------------------
nomatch: '*"mock" fixture has been deprecated*'
and: u''
________________________ test_mocker_aliases[MagicMock] ________________________
name = 'MagicMock'
@pytest.mark.parametrize('name', ['MagicMock', 'PropertyMock', 'Mock', 'call', 'ANY'])
def test_mocker_aliases(name):
> from pytest_mock import mock_module, MockFixture
test_pytest_mock.py:137:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
import inspect
import sys
import pytest
if sys.version_info >= (3, 3): # pragma: no cover
import unittest.mock as mock_module
else:
> import mock as mock_module
E ImportError: No module named mock
pytest_mock.py:9: ImportError
Sorry for the delay: * Mon Aug 29 2016 Julien Enselme <jujens> - 1.1-2 - Add python2-mock to BR so %%check passes correctly. SRPM: http://dl.jujens.eu/SRPMS/python-pytest-mock-1.1-2.fc24.src.rpm SPEC: http://dl.jujens.eu/SPECS/python-pytest-mock.spec scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15424875 > %{sum} macro is not necessary, you can write Summary: normally first time, and then use Summary: %{summary} for the subsequent ones. > You don't need to actually delete .egg-info. + package name is OK + license is acceptable (MIT) + license is specified correctly + standard python packaging is used + python_provide is used + no scriptlets present or necessary + builds and installs OK + P/R/BR look OK Package is APPROVED. Thanks for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-mock python-pytest-mock-1.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2018bc3322 python-pytest-mock-1.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6b9375ced python-pytest-mock-1.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2018bc3322 python-pytest-mock-1.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6b9375ced python-pytest-mock-1.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-pytest-mock-1.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |