Bug 1360394

Summary:	Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog
Product:	[Fedora] Fedora	Reporter:	Julien Enselme <jujens>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-22 16:52:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1360383
Bug Blocks:

Description Julien Enselme 2016-07-26 14:58:40 UTC

Spec URL: http://dl.jujens.eu/SPECS/python-pytest-watch.spec
SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-watch-4.1.0-1.fc24.src.rpm

Description:
A zero-config CLI tool that runs [pytest][], and re-runs it
when a file in your project changes. It beeps on failures and can run arbitrary
commands on each passing and failing test run.

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-11 01:51:27 UTC

Again, %sum macro is not necessary.

Again, .egg-info doesn't have to be deleted.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ provides/requires/buildrequires look OK
  (apart from missing python-watchdog)
+ %python_provide macro is used
+ modern python packaging template is used
+ no scriptlets present or necessary

Scripts are symlinked in the opposite way to what should be:
IS: ptw ← ptw-2 ← ptw-2.7
SHOULD BE: ptw → ptw-2 → ptw-2.7
(See /usr/bin/py.test* for an example.)

Comment 2 Julien Enselme 2016-08-11 10:24:56 UTC

- Remove usage of uneeded %%sum macro
- Correct symlink order
- Don't remove upstream egg-info

> Scripts are symlinked in the opposite way to what should be

Thanks for pointing that out.

SPEC URL: http://dl.jujens.eu/SPECS/python-pytest-watch.spec
SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-watch-4.1.0-2.fc24.src.rpm

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-08-11 14:16:42 UTC

Package is APPROVED.

It currently fails to install because of the python2-watchdog missing dependency. You can change it to R: python-watchdog, until python-watchdog is updated.

I'd recommend asking for co-maintainership on python-watchdog. That package requires a major update: %py3dir usage should be removed, a new version is out, tests should be enabled because the PR to package them was merged, the spec file should be cleaned up, etc. I'm sure pingou wouldn't mind the help :), and it'll be useful in the future since python-pytest-watch and python-watchdog are closely related.

Comment 4 Julien Enselme 2016-08-11 17:32:44 UTC

Thanks for the review.

> You can change it to R: python-watchdog, until python-watchdog is updated.

Will do.

> I'd recommend asking for co-maintainership on python-watchdog

Done. Working on an update.

Comment 5 Gwyn Ciesla 2016-08-11 17:48:04 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-watch

Comment 6 Fedora Update System 2016-08-11 18:43:00 UTC

python-pytest-watch-4.1.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f52d32bb1

Comment 7 Fedora Update System 2016-08-11 18:51:52 UTC

python-pytest-watch-4.1.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7631bdb73b

Comment 8 Fedora Update System 2016-08-11 18:58:24 UTC

python-pytest-watch-4.1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a4fbc7e0c

Comment 9 Fedora Update System 2016-08-12 14:28:01 UTC

python-pytest-watch-4.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a4fbc7e0c

Comment 10 Fedora Update System 2016-08-12 20:52:53 UTC

python-pytest-watch-4.1.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7631bdb73b

Comment 11 Fedora Update System 2016-08-22 16:52:52 UTC

python-pytest-watch-4.1.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-08-27 10:39:08 UTC

python-pytest-watch-4.1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.